Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • nomad-FAIR nomad-FAIR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 215
    • Issues 215
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 27
    • Merge requests 27
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nomad-labnomad-lab
  • nomad-FAIRnomad-FAIR
  • Merge requests
  • !490

Unify logic for setting metadata via files and via the api/process

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Sikter requested to merge 694-unify-logic-for-setting-metadata-via-files-and-via-the-api-process into v1.0.0 Dec 16, 2021
  • Overview 0
  • Commits 3
  • Pipelines 5
  • Changes 12

Closes #694 (closed). With these changes, MetadataEditRequestHandler handles both metadata files and requests to edit metadata through the api/by calling Upload.edit_upload_metadata, and we thus have the same validation and json format in both cases. Setting metadata via the ArchiveParser is also disallowed, at least for now (if this should be allowed, we should probably use the same class also in this case). Also refactored MetadataEditRequestHandler a bit to make it use a simpler and more consistent terminology.

Edited Dec 16, 2021 by David Sikter
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 694-unify-logic-for-setting-metadata-via-files-and-via-the-api-process