Skip to content
Snippets Groups Projects

Search edit quantity

Merged Mohammad Nakhaee requested to merge searchEditQuantity into develop

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Take a look at the comments.

    In this version you have added quite a log of new props to InputText and SearchBar, which are modifying the components quite significantly and add some re-renders that cannot be avoided.

    Instead of trying to bend these components to your needs, I would instead start creating a completely new SearchBarV2 component, that is designed from the beginning to work with displaying chips: we will need this anyways, as we plan on completely removing the chips from the filter menus. This first version you could design from scratch and make it work just for your use case: I can then later on build upon it so I can use it to completely replace the current search bar in the search and in the metainfo browser.

    Let me know if you want to discuss this more e.g. on zoom.

  • Mohammad Nakhaee added 119 commits

    added 119 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 2 commits

    • a1b63082 - Added Query Model to datamodel
    • 00bd2507 - update the filters whenever the tags are changed

    Compare with previous version

  • added 4 commits

    Compare with previous version

  • @wojasadr @mscheidg Maybe you could have some comments on the design and colors.

  • added 17 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading