Search edit quantity
Closes #1923 (closed)
Merge request reports
Activity
assigned to @mnakh
requested review from @himanel1
- Resolved by Mohammad Nakhaee
- Resolved by Mohammad Nakhaee
- Resolved by Mohammad Nakhaee
- Resolved by Mohammad Nakhaee
- Resolved by Mohammad Nakhaee
- Resolved by Mohammad Nakhaee
- Resolved by Mohammad Nakhaee
- Resolved by Mohammad Nakhaee
- Resolved by Mohammad Nakhaee
- Resolved by Mohammad Nakhaee
Take a look at the comments.
In this version you have added quite a log of new props to
InputText
andSearchBar
, which are modifying the components quite significantly and add some re-renders that cannot be avoided.Instead of trying to bend these components to your needs, I would instead start creating a completely new
SearchBarV2
component, that is designed from the beginning to work with displaying chips: we will need this anyways, as we plan on completely removing the chips from the filter menus. This first version you could design from scratch and make it work just for your use case: I can then later on build upon it so I can use it to completely replace the current search bar in the search and in the metainfo browser.Let me know if you want to discuss this more e.g. on zoom.
added 119 commits
-
b4f5b523...25ffce7a - 101 commits from branch
develop
- 25ffce7a...7f4564ca - 8 earlier commits
- fdf88714 - handle tags delete
- fbb1e46c - update deps
- b6b4f97a - added storeInArchive
- 0a2a652c - handle the new selected filter using onChange
- 6c6f7569 - pass the renderTags props to the InputText
- 63663ffb - Added SearchBarWithTags
- 8ee007d0 - fix eslint
- 69b5e49b - Added useSuggestionsHistory hook
- f1a3a3d7 - Use the useSuggestionsHistory hook within the SearchBarWithTags
- 61bf86bc - Merge remote-tracking branch 'origin/searchEditQuantity' into searchEditQuantity
Toggle commit list-
b4f5b523...25ffce7a - 101 commits from branch
added 17 commits
- 9ab4b817...619c0013 - 7 earlier commits
- 1f2b5771 - handle tags delete
- a05ea938 - update deps
- 4c642724 - added storeInArchive
- 37b1b4d7 - fix the old searchBar
- afb8bdea - Added Query Model to datamodel
- 25d358c0 - update the filters whenever the tags are changed
- 2fe4c73e - Added query
- 0adcdb4b - updated artifacts
- 5b409f9a - implemented the new queryEditQuantity
- 3caa1852 - removed the SearchBarWithTags
Toggle commit list