Added ELN base section for a Structure Files in an ELN
Closes #1436 (closed)
Merge request reports
Activity
requested review from @himanel1
assigned to @josma
Some considerations: At the moment I create the
Run
section and delete it at the end. Very ugly but does the job smoothly. This will not work with the current NGL viewer for entries with topology, for example for future use like with #1200 (closed). I was getting an error from the NGL viewer because it needed the section run too.added 2 commits
added 31 commits
-
6f063282...dac30c33 - 28 commits from branch
develop
- 3d1bc0f4 - Added ELN base section for a Structure Files in an ELN
- 3f20b8fe - Added tests
- ec8401f0 - Cleaned up comments.
Toggle commit list-
6f063282...dac30c33 - 28 commits from branch
- Resolved by Lauri Himanen
- Resolved by Lauri Himanen
- Resolved by Lauri Himanen
- Resolved by Lauri Himanen
- Resolved by Lauri Himanen
- Resolved by Jose Marquez Prieto
@himanel1 Finished with the changes. Let me know what you think, resolve the threads that you consider and feel free to merge if you feel it is ready.
Note: When testing with the MOF normalizer, the NGL viewer was crushing. I think it was complaining about not having a system section in run. Will need to be fixed in the future.
- Resolved by Lauri Himanen
- Resolved by Lauri Himanen
enabled an automatic merge when the pipeline for 0f94b26c succeeds
mentioned in commit 09df6e0f