Skip to content
Snippets Groups Projects

Added ELN base section for a Structure Files in an ELN

Merged Jose Marquez Prieto requested to merge ELN-structure-file-base-section into develop
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lauri Himanen
  • Lauri Himanen
  • Here are some comments, we can discuss them in more detail if needed.

  • Lauri Himanen added 1 commit

    added 1 commit

    • 8e6c4afe - Updated artifacts, updated imports.

    Compare with previous version

  • added 1 commit

    • 37664ef3 - Changed dile reader from pymatgen to ASE

    Compare with previous version

  • @himanel1 Finished with the changes. Let me know what you think, resolve the threads that you consider and feel free to merge if you feel it is ready.

    Note: When testing with the MOF normalizer, the NGL viewer was crushing. I think it was complaining about not having a system section in run. Will need to be fixed in the future.

  • Few minor comments

  • added 1 commit

    • 0f94b26c - Fixed try-catches after review

    Compare with previous version

  • Lauri Himanen resolved all threads

    resolved all threads

  • Lauri Himanen enabled an automatic merge when the pipeline for 0f94b26c succeeds

    enabled an automatic merge when the pipeline for 0f94b26c succeeds

  • merged

  • Lauri Himanen mentioned in commit 09df6e0f

    mentioned in commit 09df6e0f

  • Please register or sign in to reply
    Loading