ReferenceEditQuantity shows the filename of the schema and not the actual data filename

added bug label

changed the description

added question label

removed bug label

But isn't this the behaviour you would expect? I assume that Process_movpesto inherits from Task. The file movpe_sto.data.archive.yaml seems to describe a task and shows in the references as expected? I don't see the "the filename of the schema" in the ELN? The screenshot shows a files called "...data.archive.yaml" and this file also seems to contain data?

Anyhow, the ReferenceEditQuantity was recently redone anyways: #1020 (closed). @mnakh maybe you can comment on this issue?

Yes, you're right, we see there movpe_sto.data.archive.yaml. The point is that I actually put in that ReferenceEditQuantity the "process.data.archive.yaml". So I think one wants to visualize the actual data file name referenced there.

The main data file (movpe_sto.data.archive.yaml) looks like this:

data:  
  m_def: ../upload/raw/movpe_sto.schema.archive.yaml#MovpeSto_experiment 
  users:
    responsible_person: 
      - user_id: 5c87d4dd-5b6a-4759-9946-fff9bbd7cd44
  tasks: 
    - m_def: ../upload/raw/base_classes.schema.archive.yaml#TaskReference 
      name: "Epitaxial Growth"
      task: ../upload/raw/process.data.archive.yaml#data

Hi Andrea, Let me take a look on this. If you send me your files using slack it would be easier to figure out.

Hi @mscheidg,

I found that in this part it goes to the else statement

if (entry.processing_errors.length === 0) {
        setEntry(entry)
        const shownValue = resolvedUrl?.path && resolvedUrl.path !== '/data' ? 
        `${entry.mainfile}#${resolvedUrl.path}` : entry.mainfile
        setInputValue(shownValue)
        setError(null)
} else {
        setEntry(null)
        setInputValue(archive.metadata.mainfile)
}

I guess setInputValue(archive.metadata.mainfile) is wrong. Isn.t it? What should we show if the target has errors? I guess just an empty input field does not reveal enough info for the user.

The other issue is that why its status is Success when it has 11 errors.

The value of the quantity is a reference (URL). Because this one is rather technical, we wanted to show something else. Ideally whatever we show communicates to the user what the target is.

The mainfile (+ path if availble) could be ok for this purpose. I am more worried that an API call just for this is kinda expensive. I don't think it necessarily needs to indicate an error if the target somehow got compromised. Its more like a nice to have. However, once you try to navigate the error needs to be handled somehow.

I cannot say why the target processing failed from the little information here.

Concerning the process failure pointed out by Mohammad, I figured out the reason, it is due to an incorrect definition of the Argon_flow quantity in the yaml:

              argon_flow:
                type: np.float64
                unit: centimeter ** 3 / minute
                description: Argon process gas flow in to the reaction chamber
                m_annotations:
                  tabular:
                    name: Processdata/Argon flow
                    unit: centimeter ** 3 / minute 
                  eln:
                    component: NumberEditQuantity
                    defaultDisplayUnit: centimeter ** 3 / minute

As you see there is a unit definition inside the tabular key.

Hope this can help in fixing the Success status in presence of these category of errors

added backlog label and removed question label

The described issues will be covered by the new GUI implementation. Please refer all further discussion to the respective isse for the revised GUI #.

The issue seems to be stale and was closed automatically.

closed

New parent issue: #1831

mentioned in issue #1831

ReferenceEditQuantity shows the filename of the schema and not the actual data filename

Designs

Child items ...

Activity