Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • nomad-FAIR nomad-FAIR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 218
    • Issues 218
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nomad-labnomad-lab
  • nomad-FAIRnomad-FAIR
  • Merge requests
  • !826

Resolve "Refactor the relationship between FileBrowser, various entry/upload views and their contexts"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Sikter requested to merge 828-refactor-the-relationship-between-filebrowser-various-entry-upload-views-and-their-contexts into develop Sep 14, 2022
  • Overview 0
  • Commits 2
  • Pipelines 7
  • Changes 89

Final part of the refactor #828 (closed). The main idea is that instead of passing around changing context parameters in the browser, we use the data store, which acts like a kind of central cache/context, and we make sure that components keep track of urls indicating "where they are", and use these when they need to resolve any references etc. The resolving logic is also made more explicit, by instead of methods like resolveRef and resolveRefAsync using methods with a bit more narrow functionality and clearer and well-documented interface. Usually resolving a reference is now a two-stage process, first using resolveNomadUrl to calculate a url and then using the store to fetch the data, which forces the code to be very specific/explicit. Also fixes some sporadically failing gui and python tests.

Edited Sep 15, 2022 by David Sikter
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 828-refactor-the-relationship-between-filebrowser-various-entry-upload-views-and-their-contexts