Skip to content

Fixed prototype detection

Lauri Himanen requested to merge prototypes into v0.7.3

This merge request fixes issue #258 (closed).

I have made a corrected copy of from nomadcore and included it in normalizing/data. This way we don't break the nomadcore package if it still relies on the old prototype info. This will also make it easier to completely ditch nomadcore in the future.

I included a function in for updating the prototype information. This will have to be rerun e.g. if our symmetry detection routine changes. I included a quick check that will raise an Exception if trying to use the data after changing the symmetry tolerance.

I included a test that checks that at least the very basis prototypes (diamond, fcc, bcc, wurtzite, rocksalt, zincblende) are correctly matched.

Edited by Markus Scheidgen

Merge request reports