Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • nomad-FAIR nomad-FAIR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 217
    • Issues 217
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

On Thursday, 2nd February from 9 to 10.00 am there will be a maintenance with a short downtime of the GitLab service.

  • nomad-labnomad-lab
  • nomad-FAIRnomad-FAIR
  • Merge requests
  • !80

Fixed prototype detection

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lauri Himanen requested to merge prototypes into v0.7.3 Jan 24, 2020
  • Overview 2
  • Commits 8
  • Pipelines 4
  • Changes 7

This merge request fixes issue #258 (closed).

I have made a corrected copy of structure_types.py from nomadcore and included it in normalizing/data. This way we don't break the nomadcore package if it still relies on the old prototype info. This will also make it easier to completely ditch nomadcore in the future.

I included a function in structure.py for updating the prototype information. This will have to be rerun e.g. if our symmetry detection routine changes. I included a quick check that will raise an Exception if trying to use the data after changing the symmetry tolerance.

I included a test that checks that at least the very basis prototypes (diamond, fcc, bcc, wurtzite, rocksalt, zincblende) are correctly matched.

Edited Jan 24, 2020 by Markus Scheidgen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: prototypes