Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • nomad-FAIR nomad-FAIR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 151
    • Issues 151
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 27
    • Merge requests 27
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nomad-lab
  • nomad-FAIRnomad-FAIR
  • Merge requests
  • !369

Refactored search interface code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lauri Himanen requested to merge search-refactor into v1.0.0 Aug 18, 2021
  • Overview 2
  • Commits 3
  • Pipelines 2
  • Changes 42

Refactored search interface code:

  • New folder layout, improved filenames. Created new subfolders: input, menus and results. Renamed files so that the functionality can better be guessed by simply looking at the file name.
  • Created custom components for FilterMenu and items in it (see search/menus/FilterMenu.js). This greatly simplified the layout of search/menus/FilterMainMenu.js making the addition of new menu items a breeze. These new components are structured very similarly to how MaterialUI deals with Tabs.
  • Added new "Access" menu and InputRadio component. Here one can control the visibility of the calculations (controls the owner parameter in API calls.)
  • Refactored the Actions -component.
  • Several small performance tweaks.

With this refactoring done, I will continue integrating the new search interface to Uploads/Datasets and removing the old search code.

@mscheidg: can you check that the new folder layout and filenames make sense?

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: search-refactor