Skip to content
Snippets Groups Projects

Resolve "Infra requirements for API mkdocs macro"

Merged Hampus Naesstroem requested to merge 2291-infra-requirements-for-api-mkdocs-macro into develop

Currently running from nomad.mkdocs import define_env results in a ModuleNotFoundError: No module named 'fastapi' error due to the imports of the following doc strings:

from nomad.app.v1.models import query_documentation, owner_documentation
from nomad.app.v1.routers.entries import archive_required_documentation

in nomad.mkdocs.__init__.py.

By moving these imports into the only place they are used, the doc_snippet() macro, the define_env can now be imported without the infrastructure dependencies.

Closes #2291 (closed)

Edited by Hampus Naesstroem

Merge request reports

Merge request pipeline #242447 passed

Merge request pipeline passed for b25b083b

Test coverage 69.10% (0.00%) from 2 jobs
Approved by
Code Quality is loading
Test summary results are being parsed

Merged by Hampus NaesstroemHampus Naesstroem 3 days ago (Mar 10, 2025 10:08am UTC)

Merge details

  • Changes merged into develop with 3ffae368 (commits were squashed).
  • Deleted the source branch.

Pipeline passed for 3ffae368 on develop

Test coverage 69.10% (0.00%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading