Skip to content
Snippets Groups Projects

Added component for viewing the Brillouin Zone, added a uniform way of dealing with exceptions through React error boundaries (ErrorHandler.js), fixed small issues with plots and structureviewer.

Merged Lauri Himanen requested to merge brillouin-zone into v0.9.0

Before merging you can check the functionality at: https://labdev-nomad.esc.rzg.mpg.de/dev/nomad/brillouin-zone/gui/entry/id/0w6CbOiCRg2sqWzTjO1Bew/skkhFDTWZHGcgva081IiIfts_Hh7/archive/section_run/section_single_configuration_calculation:0/section_k_band

I went with a radio button for toggling between the band structure plot and the Brillouin zone viewer. Radio buttons are a fairly standard way to switch between exclusive options so I felt it to be a better fit than a simple button or switch. What do you think?

Merge request reports

Pipeline #82683 passed with warnings

Pipeline passed with warnings for 853468ba on brillouin-zone

Test coverage 77.00% (0.00%) from 1 job
Approval is optional

Merged by Markus ScheidgenMarkus Scheidgen 4 years ago (Sep 23, 2020 6:32am UTC)

Loading

Pipeline #82797 passed

Pipeline passed for 78e43ee2 on v0.9.0

Test coverage 77.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply