Skip to content
Snippets Groups Projects

Implement static nodes for workflow visualizer

Merged Alvin Noe Ladines requested to merge 1420-workflow-visualizer into develop

Merge request reports

Merge request pipeline #165726 passed

Merge request pipeline passed for 0eb03ed4

Test coverage 70.04% (-0.27%) from 2 jobs
4 environments impacted.

Merged by Alvin Noe LadinesAlvin Noe Ladines 1 year ago (May 3, 2023 12:47pm UTC)

Loading

Pipeline #165754 passed

Pipeline passed for 0baccd03 on develop

Test coverage 70.04% (-0.27%) from 2 jobs
Deployed to te‎st‎ 11 months ago
Deployed to dev‎elop‎ 1 year ago
Deployed to sta‎ging‎ 1 year ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Alvin Noe Ladines

      It might be nice if the tasks and workflows were visually more different from inputs/outputs. Maybe tasks/workflows use rectangular boxes and inputs/outputs are circular...? Also using different color hues would help. This would allow users to more easily spot and distinguish them.

      Also, the pagination mechanism for workflow steps is quite unorthodox. I had trouble understanding how it works, especially since the button jumps around. Could we have a more traditional pagination mechanism that we use e.g. for the tables? It would feels more natural at least when dealing with serial workflows, but I'm not sure if it really works out for workflows that combine serial+parallel tasks...

      I attached a mockup of an alternative that I would propose to solve these two issues. What do you think: how hard would it be to switch to it and do you see any problems with this new layout? We can also discuss this together with others.

      workflow_mockup

  • When you click on a task or an action, you transition to see it in more detail. It was not clear to me how one could navigate back to the previous view, until I realized that by clicking on the task/workflow circle you go back. I think it would be more logical to have the back/forward mechanism that we had before. What was the reason for removing it?

  • Finished the review. I think this new visualization is more readable, but there is still plenty of room for visual improvement.

    Might be reasonable to fix the code issues and then leave the visual improvements that I suggested to another MR, it's your call.

  • The gui error in the pipeline should go away after you rebase with develop.

  • Thanks for the review @himanel1 i will try to work on it next week as I am busy with the issue of removing workflow2.

  • Alvin Noe Ladines resolved all threads

    resolved all threads

  • Alvin Noe Ladines added 14 commits

    added 14 commits

    Compare with previous version

  • Alvin Noe Ladines marked this merge request as ready

    marked this merge request as ready

  • @mscheidg please have a look if I can merge this.

  • added 1 commit

    • f08fd503 - Change shape for tasks and in(out)puts

    Compare with previous version

  • Alvin Noe Ladines added 37 commits

    added 37 commits

    Compare with previous version

    Toggle commit list
  • added 1 commit

    Compare with previous version

  • added 1 commit

    • f9bdfa08 - Add click handle for in(out)puts

    Compare with previous version

  • added 1 commit

    • 76e23920 - Implemented legend and navigation buttons

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply