Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • nomad-FAIR nomad-FAIR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 225
    • Issues 225
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

On Monday, 27th March 9 a.m., the user backend of GitLab will get a reconfiguration. A new login to the web interface may be necessary.

  • nomad-labnomad-lab
  • nomad-FAIRnomad-FAIR
  • Merge requests
  • !1009

Improved documentation and handling of config classes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Sikter requested to merge improve-config-and-documentation into develop Dec 22, 2022
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 5

Did some minor improvements to the doc strings.

I also noted that if type annotation isn't added to the NomadConfig classes, the attributes might be listed in a strange order in the generated documentation, different from the order in which the attributes are defined, so I added some type annotations to make sure the logical order is preserved.

I also took myself the liberty to change the behaviour of the customize method so that it can take either a NomadConfig object or a dictionary as its sole argument (this meant I could simplify the code in some places, and I think it is cleaner. The important thing is that the dict is converted to an instance of the right NomadConfig class before we start accessing various settings, and I think this should be the responsibility of the customize method. This method also does all the checks in one place.) There was also a bug in the CLI commands relating to this (fixed now).

Edited Dec 22, 2022 by David Sikter
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: improve-config-and-documentation