Updating leap mode disk writing, leap mode folding and MPG-SKA dish 10 bit merger
1 unresolved thread
1 unresolved thread
Merge request reports
Activity
assigned to @twinchen
9 namespace psrdada_cpp { 10 namespace effelsberg { 11 namespace edd { 12 class DiskSinkLeap 13 { 14 public: 15 DiskSinkLeap(std::string prefix, int nchan); 16 ~DiskSinkLeap(); 17 void init(RawBytes& block); 18 bool operator()(RawBytes& block); 19 20 public: 21 std::string _prefix; 22 std::size_t _counter; 23 int _nchan; 24 char _header[4096]; If possible, use a global define or const to specify header sizes, block sizes, etc. Even if they will never change:
char _header[leap_header_size]; ... for (int i =0; i < leap_header_size; i++) {...}; ...is much clearer than
char _header[4096]; // 4096 is fixed leap header size ... // 4096 is fixed leap header size for (int i =0; i < 4096; i++) {...}; ...even with the comments.
changed this line in version 2 of the diff
- Resolved by Jason Wu
- Resolved by Jason Wu
added 1 commit
- 82fc80ca - got rid of unused parameters and definfing global constant
mentioned in commit b3619f8d
Please register or sign in to reply