Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • N NIFTy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ift
  • NIFTy
  • Merge requests
  • !247

Consistency: make the argument name of _flip_modes() the same for all operators

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lukas Platz requested to merge readability_consistent_renaming_mode-op_transform into NIFTy_4 Apr 25, 2018
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 5

Commit a141d2bf "resolve degenerate use of 'mode' in OperatorAdapter and LinearOperator" was pushed without ensuring consistency with other operator definitons and correct exception strings. This commit aims to resolve this.

The argument variable of _flip_modes(…) is now always called 'trafo' and the Exception thrown for invalid values of it is ValueError("invalid operator transformation"). To aid readability, numerical constants were replaced with correspondingly named constants (ADJ, INV).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: readability_consistent_renaming_mode-op_transform