Beginning with 2nd June, only the "Single Sign On" option for login to the GitLab web interface will be possible. If you don't have an MPCDF wide second factor so far, please get one at our SelfService (https://selfservice.mpcdf.mpg.de). The GitLab internal second factor will not work.
Closes #339 (closed)
Options:
_kernels.py files# noqa to all omp lines to ignore it in the linter (This is of course the worst option)I don't like option 1 since 1) We actually do want to format the kernel files, 2) not all kernel files are/will be consistently named, 3) there may be OMP tags in other files too.
I don't like option 3 since I don't think we should rely on using code comments that are specific to autopep8 and this solution is very prone to bugs in the future due to forgetting to add the tag.
I don't really like option 2 either, since I believe there should be a space after # for comments but I implemented it anyway and ran struphy format on the following kernel files:
src/struphy/bsplines/bsplines_kernels.py
src/struphy/eigenvalue_solvers/kernels_2d.py
src/struphy/pic/accumulation/accum_kernels.py
src/struphy/pic/pushing/pusher_kernels.pyPlease check that they are correct