Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • nomad-FAIR nomad-FAIR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 217
    • Issues 217
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 28
    • Merge requests 28
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nomad-labnomad-lab
  • nomad-FAIRnomad-FAIR
  • Merge requests
  • !77

Improved system_type detection

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lauri Himanen requested to merge surfaces into v0.7.3 Jan 21, 2020
  • Overview 2
  • Commits 8
  • Pipelines 1
  • Changes 20

As per issue #257 (closed) I updated the system type detection to use the classifier implementation provided by MatID. It supports also a distinction between surfaces and 2D materials that cannot be made with just the periodicity check. I have included a simple test case for all the supported types.

The change effectively splits the system type "surface / 2D" into "surface" and "2D". This change is only tested at the normalization level, the changes in the GUI have not been checked.

The old system detection code was also using the periodic dimensions as a backup if the dimensionality check failed. This is now removed because the periodic dimensions do not reveal the correct system type (for computational reasons pretty much all calculations are made with fully periodic simulation cell. In reality the simulated system can however be isolated from periodic copies by vacuum). Thus if the system_check fails, the value is left as unavailable.

Edited Jan 21, 2020 by Lauri Himanen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: surfaces