Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • nomad-FAIR nomad-FAIR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 222
    • Issues 222
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nomad-labnomad-lab
  • nomad-FAIRnomad-FAIR
  • Merge requests
  • !1073

Resolve "Plot Reference to Missing SubSection Crashes GUI"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hampus Naesstroem requested to merge 1313-plot-reference-to-missing-subsection-crashes-gui into develop Feb 02, 2023
  • Overview 40
  • Commits 15
  • Pipelines 5
  • Changes 6

Aim

Closes #1313 (closed)

Closes #1311 (closed)

This means that:

  1. Non-instantiated subsections will not be plotted until they are instantiated (Bug fix)
  2. The paths for plot annotations now support a python like slice operator (start:end) (feature)

For example:

plot:
  - x: my_middle_sections/:/my_sub_sections/-2:/x
    y: my_middle_sections/:/my_sub_sections/-2:/y

will plot data from the last two my_sub_sections of all the my_middle_sections. This means that passing the following data:

data:
  m_def: '#/MyTopSection'
  my_middle_sections:
    - name: Middle 1
      my_sub_sections:
      - name: Sub 1
        x: [0,1]
        y: [1,2]
      - name: Sub 2
        x: [0,0.5]
        y: [1,2]
      - name: Sub 3
        x: [0.2,0.4]
        y: [1.5,3]
    - name: Middle 2
      my_sub_sections:
      - name: Sub 1
        x: [0.5,1]
        y: [3,1]
      - name: Sub 2
        x: [0.5,1.5]
        y: [-1,2]

Will give the following plot:

image

Tasks

  • Add tests:
    • Non-instantiated SubSection
    • Wildcard
    • Legend labels
  • Fix bugs:
    • GUI crash on non-instantiated subsection #1313 (closed)
  • Add features:
    • Wildcard for repeating subsections #1311 (closed)
    • Legend labels for repeating sections
  • Add documentation:
    • Information on how to use the new features
    • Adding links to plotly javascript docs
    • Potentially a link to the plot examples? → Will need new issue
Edited Feb 10, 2023 by Hampus Naesstroem
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1313-plot-reference-to-missing-subsection-crashes-gui