Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • nomad-FAIR nomad-FAIR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 217
    • Issues 217
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nomad-labnomad-lab
  • nomad-FAIRnomad-FAIR
  • Merge requests
  • !1037

Resolve "refactoring eln base sections"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hampus Naesstroem requested to merge 1152-refactoring-eln-base-sections into develop Jan 16, 2023
  • Overview 87
  • Commits 25
  • Pipelines 20
  • Changes 20

Closes #1152 (closed) by adding the Substance and Ensemble classes with their superclass System to nomad.datamodel.metainfo.eln. In addition the SampleID class was modified to get automatically filled by data from the metadata.main_author. Merge also includes a fix to the GUI for rendering undefined times. Two tests have been added to test the normalizers of the three added classes. The test coverage of nomad/datamodel/metainfo/eln/init.py is therefore the same 75 % as before the additions.

EDIT: Implemented new methods in the new Formula class and updated the Substance class to use these. Ready for review.

Edited Jan 26, 2023 by Hampus Naesstroem
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1152-refactoring-eln-base-sections