Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • nomad-FAIR nomad-FAIR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 219
    • Issues 219
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 28
    • Merge requests 28
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nomad-labnomad-lab
  • nomad-FAIRnomad-FAIR
  • Merge requests
  • !102

First version of EncyclopediaNormalizer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lauri Himanen requested to merge encyclopedia into v0.7.10 Mar 25, 2020
  • Overview 0
  • Commits 158
  • Pipelines 1
  • Changes 68

The first version of EncyclopediaNormalizer is now ready to be merged into a production branch. This first version is still lacking tools for handling phonon/elastic/thermal properties which will be added in a later phase.

The EncyclopediaNormalizer has been extensively tested locally and on a separate deployment machine. In particular:

  • The execution time for the normalizer is very similar to existing ones (~100ms)
  • The normalizer has been tested on a separate deployment with ~8000 entries: no unexpected expections are raised, for cases where the encyclopedia data cannot be created the normalizer will simply not create the encyclopedia section and will instead log the reason.
  • This addition does not affect other parts of the infrastructure: changes are almost completely isolated to EncyclopediaNormalizer
  • The normalizer comes with basis regresssion tests that test for metainfo correctness, the correct detection of identical materials and the creation of hashes used for grouping calculations.
  • The produced data has been also checked through the encyclopedia GUI both locally and on the staging machine.

Although the normalizer is not yet fully finished, I think merging it to a production branch would make sense. This way we can incrementally test it's behaviour on production data before moving to building the secondary normalizers for phonon/elastic properties and before building the API for using it. I expect that the metainfo created for the Encyclopedia will be quite unstable for a while, so it will still undergo quite a bit of restructuring.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: encyclopedia