Type mismatch in dependencies
-
https://github.com/nomad-coe/nomad-schema-plugin-run/commits/type-mismatch/
- 67486f9ca17cc599e9ff75831ee8f414facddf83
- 02e110d4221fc80144c89cce73918db8f7c65274
-
https://github.com/nomad-coe/electronic-parsers/commits/type-mismatch/
- 6885db180dbf86f824c14fa4276d79cca571357c
-
https://github.com/nomad-coe/workflow-parsers/commits/type-mismatch/
- ba85215806a7a59f194da0fcd44f4b09df951b9f
In the above repositories, the schemas contain incompatible definitions that would fail at least one of the tests if the strict type/shape check is implemented.
The listed commits provide minimum changes that are needed to make the tests pass. To validate, just check out branch 1947-repo-failure
and run the tests.
The changes applied to most quantities would have the following form:
type=np.dtype(np.float64)
--> type=m_float64(dtype=np.float64).no_shape_check()
The .no_shape_check()
disables the shape check, indicating that the data parsed for that particular quantities has an incompatible shape compared to the one defined in the schema. The .no_type_check()
bypasses the type check, indicating that the data fed cannot be converted to the desired type without loss of precision.
Those definitions need to be fixed by providing the correct type and shape (as if the new typing system does not exist). But mainly the parsers shall perform strict data check and provide definition compliant data in the first place.