Cleaning the normalizers
This is a super-issue for collecting minor corrections to the normalizers.
-
@ladinesa stated that some of the imports in nomad/normalizing/method.py
fromnomad.datamodel.results
are misleading, since they do not overwrite those inMethod
, and should be imported from there. -
the normalize()
method innomad/normalizing/normalizer.py/SystemBasedNormalizer
strongly relies on the__normalize_system
innomad/normalizing/system.py/SystemNormalizer
via several interlinking methods. This connection could be made to be more direct and traceable. -
the MethodNormalizer
normalizes themethod
sections both inrun
andresults
. The distinction could be made clearer by separating these into 2 methods that are called bynormalize()
. -
as suggested by @ladinesa, simplify the kpoints
terminology inrun.method.eigenvalues
.