Avoid crash and notice not found contacts to admins

contacts.js

@@ -73,7 +73,7 @@ const logger = require('./logger');
  */
 exports.getContactDetails = async (offlineValidatorsArray) => {
   logger.log('Offline validators are: ', offlineValidatorsArray);
-  let result = [];
+  let offlineContacts = [];
 
   // Prepare data
   let techies = await readCSVtoJson(TECHIE_FILE);
@@ -83,7 +83,7 @@ exports.getContactDetails = async (offlineValidatorsArray) => {
   let groupedConsortium = groupContactsByInstitution(consortium);
 
   console.log(groupedTechies)
-  let noContacts = []
+  let notFoundContacts = []
   for (validator of offlineValidatorsArray) {
     let address = validator.address;
     let institution = addressInstitutionMap[address];
@@ -96,22 +96,22 @@ exports.getContactDetails = async (offlineValidatorsArray) => {
     } else if (groupedConsortium[institution]) { // all other contacts we have
       contacts = groupedConsortium[institution];
     } else {  // no contacts
-      noContacts.push(address);
+      notFoundContacts.push({ institution, address });
     }
 
     // Add address field to contact object
-    let contactsWithAddress = contacts && contacts.map(contact => { // if contacts undefined, throw below.
+    if (contacts) {
+      let contactsWithAddress = contacts.map(contact => { // if contacts undefined, throw below.
         return {
           address: address,
           lastOnline: validator.lastOnline,
           ...contact
         }
       })
-    result.push(contactsWithAddress);
+      offlineContacts.push(contactsWithAddress);
     }
-  if (noContacts.length > 0)
-    throw new Error('Couldnt find contacts for addresses ' + noContacts.join())
-  return result;
+  }
+  return { offlineContacts, notFoundContacts };
 }
 
 /**

email.js

@@ -41,6 +41,7 @@ exports.sendNoticeMails = (contactsArray) => {
  * @param {Error} error - the thrown Error object
  */
 exports.sendErrorEmails = (emails, error) => {
+  logger.log('Sending error emails to ' + emails.join() + 'about: ' + error)
   const message = {
     from: `bloxberg Validator Monitoring <monitoring@bloxberg.org>`,
     to: emails,
@@ -54,6 +55,33 @@ exports.sendErrorEmails = (emails, error) => {
   return transport.sendMail(message);
 }
 
+/**
+ * Function to send error emails to admins when the script fails.
+ * 
+ * @param {Array} emails - array of email strings as receivers
+ * @param {Error} error - the thrown Error object
+ */
+exports.sendNotFoundEmails = (emails, notFoundContacts) => {
+  logger.log('Sending not found emails to ' + emails.join() + ' for the addresses: ' + notFoundContacts.map(contact => contact.address).join())
+  const message = {
+    from: `bloxberg Validator Monitoring <monitoring@bloxberg.org>`,
+    to: emails,
+    subject: '❗ Contact Not Found: bloxberg Validator Offline',
+    text: `The following validators do not have an assigned contact and 
+          hence were not able to be contacted. If the institution name is undefined, 
+          it means an associated institution for the address couldn't be found in Cobra input.
+          Otherwise the institution has an associated address but is missing any contacts. \n\n` +
+      notFoundContacts.map(contact => {
+        return `Institution: ${contact.institution} \n\n
+              Address: ${contact.address}\n\n`
+      }).join()
+
+  };
+
+  // return setTimeout(() => Promise.resolve(`Email sent to ${institution}: ${email}`), Math.random() * 1000 * 2) // Debug with randomly resolved Promises.
+  return transport.sendMail(message);
+}
+
 /**
  * @function to send a notice email to the validator input. 
  * 

index.js

 
 const { getValidatorArray } = require('./validators');
-const { sendNoticeMails, sendErrorEmails } = require('./email');
+const { sendNoticeMails, sendErrorEmails, sendNotFoundEmails } = require('./email');
 const { getContactDetails } = require('./contacts');
 const schedule = require('node-schedule');
 const logger = require('./logger');
@@ -28,12 +28,15 @@ function checkValidatorsAndSendEmails() {
       logger.log("Got the online status for validators: ");
       return getContactDetails(offlineValidatorsArray);
     })
-    .then(offlineContacts => {
-      return sendNoticeMails(offlineContacts);
+    .then(({ offlineContacts, notFoundContacts }) => {
+      return Promise.all([
+        sendNoticeMails(offlineContacts),
+        sendNotFoundEmails(ERROR_CONTACTS, notFoundContacts)
+      ]);
     })
     .catch(err => {
       logger.error("SOMETHING WENT WRONG")
-      logger.error(err)
+      logger.error(err.stack)
       sendErrorEmails(ERROR_CONTACTS, err);
     })
 }

logger.js

@@ -19,7 +19,7 @@ const fileLogOptions = {
 const mainLoggers = logger.createLogger({
   level: 'info',
   format: format.combine(
-    format.metadata({ fillExcept: ['timestamp', 'level', 'message'] })
+    format.metadata({ fillExcept: ['timestamp', 'level', 'message', 'stack'] })
   ),
   transports: [
     new transports.DailyRotateFile({