Skip to content
Snippets Groups Projects
Commit ba8442d5 authored by Philipp Arras's avatar Philipp Arras
Browse files

Add TODOs

parent 48499441
Branches
Tags
No related merge requests found
Pipeline #93768 passed
......@@ -9,6 +9,14 @@ import nifty7 as ift
class AllreduceSum(ift.Operator):
def __init__(self, oplist, comm):
# FIXME Currently all operators in the oplist need to have the same
# domain and target. In NIFTy, we generally support the addition of
# operators that have different domains (not all keys need to be present
# in all domains). This could be done here as well.
# FIXME If all operators in oplist are linear operators, we could
# automatically instantiate AllreduceSumLinear.
self._oplist, self._comm = oplist, comm
self._domain = ift.makeDomain(
_get_global_unique(oplist, lambda op: op.domain, comm)
......
......@@ -53,6 +53,7 @@ def allclose(gen):
def test_mpi_adder():
# FIXME Write tests for non-EnergyOperators and linear operators.
ddomain = ift.UnstructuredDomain(4), ift.UnstructuredDomain(1)
comm, size, rank, master = ift.utilities.get_MPI_params()
data = ift.from_random(ddomain)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment