Skip to content

BrokenLogarithmicGrid & minor fixes and adjustments

Laurin Söding requested to merge grid_tweaks into NIFTy_8
  • Implemented a broken logarithmic grid.
  • Fixed some instances where index2coord was not the inverse of coord2index even for integer inputs due to floating point inaccuracies and type casting rules.
  • Expanded the combinations of parameters that HealPixGrid can be initialised with and more rigorous input checks.
  • Fixed some bugs where super().coord2index would get self as an argument.
  • Fixed index2volume for the LogarithmicGrid
  • Renamed HPLogRGridAtLevel to HPRadialGridAtLevel to account for the fact that it work with arbitrary radial grids.
  • Implemented index2volume for HPRadialGridAtLevel.

Open questions:

  • Should HPBrokenLogRGrid be in the top-level namespace?
  • Which classes in grid_impl.py should be dataclasses and why?
  • Consistency: When to allow for **kwargs in index2coord etc?

Merge request reports