Tweak ELBO arguments and fix #eigenvector handling (!971) · Merge requests · ift / NIFTy · GitLab

Snippets Groups Projects

Merged Matteo Guardiani requested to merge 33-github-enhance-elbo into NIFTy_8 5 months ago

Closes issue 33 on github.

Activity

Matteo Guardiani added d2o label 5 months ago

added d2o label
Matteo Guardiani assigned to @matteani 5 months ago

assigned to @matteani
Matteo Guardiani added New feature label 5 months ago

added New feature label
Matteo Guardiani removed d2o label 5 months ago

removed d2o label
Matteo Guardiani removed New feature label 5 months ago

removed New feature label
Matteo Guardiani added 1 commit 4 months ago
added 1 commit

bd836ead - 33-github-enhance-elbo: improve batching.

Compare with previous version
Matteo Guardiani added 1 commit 4 months ago
added 1 commit

4ebbbcae - 33-github-enhance-elbo: lambdas to functions.

Compare with previous version
Matteo Guardiani added 77 commits 4 months ago
added 77 commits

4ebbbcae...b7404bf0 - 10 commits from branch NIFTy_8

b7404bf0...5bb1f222 - 57 earlier commits

7fc274e0 - mean_model_mf: add option to have mean model.

7a804e06 - mean_model_mf: update builder.

9d154454 - mean_model_mf: fix for vector model domains.

716b1499 - mean_model_mf: small fixes.

992764b6 - mean_model_mf: big fixes.

63b1cfb6 - mean_model_mf: rename helper function for clarity

f4395967 - mean_model_mf: fix for new NIFTy_8.

86f883f6 - 33-github-enhance-elbo: avoid duplicate code. Cleanup.

6cbd558f - 33-github-enhance-elbo: improve batching.

7f89cf57 - 33-github-enhance-elbo: lambdas to functions.

Compare with previous version
Toggle commit list
Matteo Guardiani added 3 commits 4 months ago
added 3 commits

269383e2 - 33-github-enhance-elbo: avoid duplicate code. Cleanup.

bf02f8c4 - 33-github-enhance-elbo: improve batching.

1d794e4a - 33-github-enhance-elbo: lambdas to functions.

Compare with previous version
Matteo Guardiani added 1 commit 4 months ago
added 1 commit

cbbb9794 - 33-github-enhance-elbo: fix tests.

Compare with previous version
Matteo Guardiani marked this merge request as ready 2 months ago

marked this merge request as ready
Matteo Guardiani requested review from @gedenhof 2 months ago

requested review from @gedenhof
Gordian Edenhofer @gedenhof started a thread on an old version of the diff 2 months ago

Resolved 2 months ago by Matteo Guardiani
Last reply by Gordian Edenhofer 2 months ago

Gordian Edenhofer @gedenhof started a thread on an old version of the diff 2 months ago

src/re/evidence_lower_bound.py

     if tot_dofs == n_eigenvalues:
         # Compute exact eigensystem
         if verbose:
             logger.info(f"Computing all {tot_dofs} relevant " f"metric eigenvalues.")
             logger.info(f"Computing all {tot_dofs} relevant "

Gordian Edenhofer @gedenhof started a thread on an old version of the diff 2 months ago

Resolved 2 months ago by Matteo Guardiani

Gordian Edenhofer @gedenhof started a thread on the diff 2 months ago

Resolved 1 month ago by Matteo Guardiani

Gordian Edenhofer @gedenhof started a thread on an old version of the diff 2 months ago

Resolved 2 months ago by Matteo Guardiani

Gordian Edenhofer @gedenhof started a thread on an old version of the diff 2 months ago

Resolved 2 months ago by Matteo Guardiani

Gordian Edenhofer @gedenhof · 2 months ago

Maintainer

Resolved 4 weeks ago by Matteo Guardiani

Thanks for this PR! I think it looks good!

As we are breaking the interface, we might consider more interface breaking changes WDYT?
Last reply by Matteo Guardiani 1 month ago

Gordian Edenhofer requested changes 2 months ago

requested changes

Please register or sign in to reply