Fix potential color rendering error in multifrequency plotting

While refactoring the multifrequency plotting, I think I discoverd an error in the wavelength-color mapping.

To test the routine, I created an mf image in which each column contains contribution from only one wavelength. Below are images how the nifty plotting routine in the current NIFTy_8 branch renders this image ("original") and how my (supposedly) fixed routine does ("new_fixed").

I expect a test image like described to be rendered into the familiar rainbow colors known of visualizations of the visibible light spectrum, but the original RGB mapping instead produces some red, lots of yellow, some turquise, and lots of violet.

The problem seems to be that the original routine first applies the rgb mapping and then the logarithmic "sensitivity" correction, while it should be the other way around. The source branch of this MR contains the code producing the "new_fixed" output.

@mtr @pfrank What do you think? Was the original behavior desireable, or is the new behavior better? I lean towards the latter, if our goal is to map spectral data to the visible spectrum without color distortion.

src/plot.py

@@ -300,13 +300,13 @@ class MultiFrequencyToRGBProjector:
         tgt_shp = spectral_data.shape[:-1]+(3,)
         spectral_data = spectral_data.reshape((-1, n_freqs))
 
-        raw_rgb_data = np.tensordot(spectral_data, self._mapping_f_space_bins_to_rgb, axes=[1, 0])
+        max_spectral_data = spectral_data.max() if brightness_scale_anchor is None else brightness_scale_anchor
+        min_spectral_data = max_spectral_data / dynamic_range
+        spectral_data_log = self._to_logscale(spectral_data, min_spectral_data, max_spectral_data)
 
-        max_raw_rgb_data = raw_rgb_data.max() if brightness_scale_anchor is None else brightness_scale_anchor
-        min_raw_rgb_data = max_raw_rgb_data / dynamic_range
-        raw_rgb_data_log = self._to_logscale(raw_rgb_data, min_raw_rgb_data, max_raw_rgb_data)
+        raw_rgb_data = np.tensordot(spectral_data_log, self._mapping_f_space_bins_to_rgb, axes=[1, 0])
 
-        sRGB_data = self.transform_raw_rgb_values_to_sRGB(raw_rgb_data_log)
+        sRGB_data = self.transform_raw_rgb_values_to_sRGB(raw_rgb_data)
         sRGB_data = sRGB_data.reshape(tgt_shp)
 
         # ensuring outputs lie between zero and one