Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • N NIFTy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ift
  • NIFTy
  • Merge requests
  • !820

Fix `ift.Field.vdot` breaking with np.uint32 and other integer types

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lukas Platz requested to merge fix_ducc_dispatcher into NIFTy_8 Dec 09, 2022
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

Hi Martin,

I just stumbled over ducc0.misc.vdot not multiplying doubles and integers, which is required in the PoissonianEnergy. It seems Philipp Arras did so, too, a while ago, but unfortunately his mitigation was incomplete, as it did only catch np.int64s.

Is there a double*integer vdot in ducc0 that we could call instead of the conversion?

While at it: I noticed ift.PoissonianEnergy enforces integer-typed data fields (sensible for Poisson counts), but then passes them directly to vdot, triggering an int->double conversion in each application. Should we cast the data field to double in the initialization of PoissonianEnergy after the integer check to avoid this?

Cheers, Lukas

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_ducc_dispatcher