Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • N NIFTy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ift
  • NIFTy
  • Merge requests
  • !403

operator.py: Raise not-implemented in matmul call

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gordian Edenhofer requested to merge nifty6_notimplemented into NIFTy_6 Jan 23, 2020
  • Overview 6
  • Commits 3
  • Pipelines 2
  • Changes 2

Contrary to other overloaded operators, the __matmul__ call apparently needs to raise an exception instead of returning NotImplemented. This behaviour can be seen for example in:

psp = ift.RGSpace(512)
m = ift.MaskOperator(ift.Field.from_raw(psp, np.random.randint(0, 2, 512)))
m(ift.from_random("normal", m.domain).val) is NotImplemented

which should be invalid and raise an exception but previously returned True instead.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nifty6_notimplemented