Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • N NIFTy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ift
  • NIFTy
  • Merge requests
  • !22

Fixed a lot of small bugs. Removed the plotting routines from most of the spaces.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Theo Steininger requested to merge refactor_spaces_comments_from_theo into refactor_spaces Aug 19, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 5

Fixed furthermore:

  • Let's undo the changes in the RGSpace.init (see the comment on gitlab)
  • The HPSpaceParadict still has distances in the list.
  • HPSpace.copy: Is this method really necessary? The one from Space should be sufficient, right?
  • HPSpace.total_volume is missing
  • Unnecessary imports of random, LMSpace,... in hp_space.py
  • I removed the plotting functionality from the space classes.
  • GLSpace.copy should also not be necessary
  • GLSpace.dim is missing
  • GLSpace.vol should be called total_volume. Also its implementation is defect: there is no self.distances for GLSpace. The total volume is just 4*pi.
  • Use nifty_utilities.cast_axis_to_tuple in order to sanitize axes input in GLSpace.weight
  • typo in new_shape = np.ones(x.shape)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: refactor_spaces_comments_from_theo