Skip to content
Snippets Groups Projects

Removed the lines where pointing variables was trying to access ra and dec members.

Closes issue #2 (closed).

Merge request reports

Pipeline #65684 failed

Closed by Alessio BertiAlessio Berti 5 years ago (Dec 18, 2019 3:31pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Why would you like to remove these?

  • ah sorry, it was not clear from the merge request that it is related to this issue: #2 (closed)

    There I explain the reason why those lines should be removed.

  • Hi Alessio, indeed, ra & dec are not present in default ctapipe, but the containers should exist in the ctapipe-mpp master. They don't & it still doesn't work for you? Anyhow, can still discuss whether we want at all to incorporate into ctapipe reading ra,dec from the MARS files (i.e., the MARS internal alt,az->ra,dec calculation result). I did it once only to check against the Astropy ra,dec calculation. In fact, I could quite well reproduce the MARS ra,dec output, but only after considering the atmospheric conditions in the Astropy calculation (see https://github.com/cta-observatory/ctapipe/pull/1210; still, MARS is using a slightly different standard atmospheric model, iirc).

  • Hi @mhuetten, you are right. When I encountered this problem (two weeks ago, before we decide to use ctapipe-mpp as starting point) I was still using the standard ctapipe. I see that these containers exit in ctapipe-mpp. Therefore this merge request can be closed.

  • closed

  • mentioned in issue #2 (closed)

Please register or sign in to reply