Skip to content
Snippets Groups Projects

Export txt and image configuration

Created by: meelod

Changes proposed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1389 1405 'species' in the function is a dictionary that contains the names of the species
1390 1406 EX: {'CO': 'carbon', 'empty': ''}
1391 1407
1392 """
1393 if filename_csv == "" and export_csv==True:
1394 filename_csv = "species_coords.csv"
1408 'matrix_format' has two types of options: meshgrid and cartesian. Cartesian return as a csv with (x,y,z) format, and the meshgrid format
  • Created by: AdityaSavara

    Please check this line. This looks like it is supposed to be in the comments, but it looks like it is not in the comments.

  • Martin Deimel @mdeimel1 started a thread on commit d138b59b
  • 1389 1405 'species' in the function is a dictionary that contains the names of the species
    1390 1406 EX: {'CO': 'carbon', 'empty': ''}
    1391 1407
    1392 """
    1393 if filename_csv == "" and export_csv==True:
    1394 filename_csv = "species_coords.csv"
    1408 'matrix_format' has two types of options: meshgrid and cartesian. Cartesian return as a csv with (x,y,z) format, and the meshgrid format
    1409 returns as a csv with a XX, YY format
    1395 1410
    1396 filename_csv.replace(".csv", "") + ".csv"
    1411 """
  • Martin Deimel @mdeimel1 started a thread on commit d138b59b
  • 1432 1465 [0, 4]]]
    1433 1466
    1434 1467 'config' is expected to be a nested 4d array that contains the species's coordinates
    1435 EX: [[[[0]], [[1]], [[1]], [[0]]]]
    1468 EX: [[[[0]], [[1]], [[2]], [[0]], [[3]], [[2]]]]
    1436 1469 'species' is exptected to be a dictionary that contains the names of the species
    1437 1470 EX: {'CO': 'carbon', 'empty': ''}
    1438 1471
    • Created by: AdityaSavara

      The "matrix format" and cartesian argument needs to be defined and/or explained in the comments for this function also.

  • Martin Deimel @mdeimel1 started a thread on commit 09d47731
  • 1437 1486 EX: {'CO': 'carbon', 'empty': ''}
    1438 1487
    1488 'matrix_format' has two types of options: meshgrid and cartesian. Cartesian return as a csv where each row
    1489 represents the coordinates for a single species, and the meshgrid format returns as a csv with a XX, YY format
    1490 EX: Cartesian
    1491 [[0 10] [0 11] [0 18] [1 6] [2 3] [2 11] [2 13]] -> This is CO
    1492 [[0 0] [0 1] [0 2] [0 3] [0 4] [0 5] [0 6]] -> This is empty
    1493
    1494 EX: Meshgrid
    1495 [[0, 1, 1, 0, 1, 0],
    1496 [1, 1, 1, 0, 1, 0],
    1497 [0, 1, 1, 0, 1, 0],
    1498 [1, 1, 0, 0, 1, 0],
    1499 [1, 0, 1, 1, 1, 0],
    1500 [1, 0, 1, 0, 1, 0]]
    1501
    • Created by: AdityaSavara

      I now see that the comments starting and ending point were correct and that I just misinterpretted what I was looking at.

      The additional matrix_format comments you added are helpful. For the Meshgrid, you should also add a little bit more to explain that in this example meshgrid the "0" is empty and the "1" is CO, but that in general the meshgrid can have higher numbers (like 3) if there are enough species in the model.

  • Created by: meelod

    Expected Unit Tests passed. Ready to Merge

  • Created by: AdityaSavara

    Review: Approved

    This merge should have gone to develop rather than master, but I will approve it anyway.

  • Merged by: AdityaSavara at 2022-04-12 19:50:13 UTC

  • closed

  • Please register or sign in to reply
    Loading