Adapting read_moments and read_histogram in DNS.py
There are a few things that make the read_moments
and read_histogram
methods in DNS.py
less useful than they could be. I can fix them, but I'm not sure which ones you implemented on purpose this way:
- Both methods take the mean over time. Since we are already reading the whole time series into memory, why can't we return the full array?
- If you insist on aggregating over time, then in
read_moments
, we should at least take the minimum of the minima and the maximum of the maxima instead of their mean. - Can we save the result into
self.statistics
?