Missing/wrong constant shifts in unitsData.json
unitsData.json
(generated by nomad dev units
) contains data for value shifts during temperature unit conversions. The data for celsius and fahrenheit (probably also atomic units) is wrong (or better missing). Celsius and Fahrenheit use the same data as Kelvin. Rendering all conversions to Kelvin wrong. Basically there is not constant to shift from C to K. Only from K to C.
As a consequence the NumberEditQuantity cannot be used to enter Tempratures in non Kelvin units.
Tasks:
-
Fix the temperature offset data in unitsData.js. -
Refactor the unit system so that all conversions are done using the Quantity
andUnit
classes. -
Added possibility to do the conversion from one unit to another without specifying a system. E.g. to convert from Celsius to Fahrenheit: const a = new Quantity(10, 'celsius') const b = a.to('fahrenheit') console.log(b.value, b.unit.label)