From b1b4002f788b1d717d95d7e35cc4849457e9b50e Mon Sep 17 00:00:00 2001
From: Theodore Chang <tlcfem@gmail.com>
Date: Fri, 16 Aug 2024 19:55:39 +0200
Subject: [PATCH] Commit
---
nomad/datamodel/data.py | 4 ++--
nomad/metainfo/metainfo.py | 4 +++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/nomad/datamodel/data.py b/nomad/datamodel/data.py
index 6fcfd9080d..f5aa652d28 100644
--- a/nomad/datamodel/data.py
+++ b/nomad/datamodel/data.py
@@ -208,7 +208,7 @@ class UserReference(Reference):
return value.user_id
-user_reference = UserReference()
+user_reference = UserReference
class AuthorReference(Reference):
@@ -233,7 +233,7 @@ class AuthorReference(Reference):
raise ValueError(f'Cannot serialize {value}.')
-author_reference = AuthorReference()
+author_reference = AuthorReference
class Query(JSON):
diff --git a/nomad/metainfo/metainfo.py b/nomad/metainfo/metainfo.py
index 2cf68748a7..83a20b3094 100644
--- a/nomad/metainfo/metainfo.py
+++ b/nomad/metainfo/metainfo.py
@@ -479,8 +479,10 @@ class Reference:
def _check_shape(self, value):
dimension: int = 0
target = value
- while isinstance(target, list) and len(target) > 0:
+ while isinstance(target, list):
dimension += 1
+ if len(target) == 0:
+ break
# assuming consistent data
target = target[0]
--
GitLab