Commit 4242ab90 authored by Iker Hurtado's avatar Iker Hurtado
Browse files

Several minor improvements on 'New quantities issue' implementation

parent 03331eca
Pipeline #24378 passed with stages
in 6 seconds
......@@ -2481,14 +2481,6 @@
<b><span info-sys-data="structure-type">Structure type</span></b>:
<span class="structure-type-value" ></span>
</div>
<div class="structure-prototype-field" style="display: none">
<b><span info-sys-data="structure-prototype">Structure prototype</span></b>:
<span class="structure-prototype-value" ></span>
</div>
<div class="strukturbericht-field" style="display: none">
<b><span info-sys-data="strukturbericht">Strukturbericht designation</span></b>:
<span class="strukturbericht-value" ></span>
</div>
</div>
</div>
......@@ -2624,11 +2616,6 @@
this.spaceGroupValue = this.element.querySelector('.space-group-value');
this.structTypeField= this.element.querySelector('.structure-type-field');
this.structTypeValue= this.element.querySelector('.structure-type-value');
this.structPrototypeField= this.element.querySelector('.structure-prototype-field');
this.structPrototypeValue= this.element.querySelector('.structure-prototype-value');
this.strukturberichtField= this.element.querySelector('.strukturbericht-field');
this.strukturberichtValue= this.element.querySelector('.strukturbericht-value');
//this.band_gap = this.element.getElementsByClassName('e-struct-field')[0];
//fields= this.element.getElementsByClassName('method-field');
......@@ -2729,17 +2716,12 @@
this.systemType.textContent= data.system_type;
this.structTypeField.style.display =
(isBulk && data.structure_type !== null ? 'block' : 'none');
this.structPrototypeField.style.display =
(isBulk && data.structure_prototype !== null ? 'block' : 'none');
this.strukturberichtField.style.display =
(isBulk && data.strukturbericht_designation !== null ? 'block' : 'none');
this.spaceGroupField.style.display = (isBulk ? 'block' : 'none');
if (isBulk){
this.structTypeValue.textContent= data.structure_type;
this.structPrototypeValue.textContent= data.structure_prototype;
this.strukturberichtValue.textContent= data.strukturbericht_designation;
this.spaceGroupValue.textContent = data.space_group_number;
this.spaceGroupValue.textContent = data.space_group_number+
' ('+data.space_group_international_short_symbol+')';
InfoSys.addElementToInfoSystem(this.spaceGroupValue,
'space-group.value:'+data.space_group_number);
}
......@@ -4195,7 +4177,7 @@
<div class="footer-flex" style="display: none">
<div class="fields-container"
style="flex-basis: 60%; border-right: 1px solid #E4E4E4; ">
style="flex-basis: 70%; border-right: 1px solid #E4E4E4; ">
<div>
<b><span info-sys-data="crystal-system">Lattice</span></b>:
......@@ -4211,7 +4193,7 @@
</div>
</div>
<div style="flex-basis: 40%; margin-left: 40px;">
<div style="flex-basis: 30%; margin-left: 30px;">
<div class="fields-container">
<div><b><span info-sys-data="wyckoff-position-population">Wyckoff sites</span></b></div>
<div class="wyckoff-sites-value"> </div>
......
......@@ -49,14 +49,6 @@ class Overview {
<b><span info-sys-data="structure-type">Structure type</span></b>:
<span class="structure-type-value" ></span>
</div>
<div class="structure-prototype-field" style="display: none">
<b><span info-sys-data="structure-prototype">Structure prototype</span></b>:
<span class="structure-prototype-value" ></span>
</div>
<div class="strukturbericht-field" style="display: none">
<b><span info-sys-data="strukturbericht">Strukturbericht designation</span></b>:
<span class="strukturbericht-value" ></span>
</div>
</div>
</div>
......@@ -192,11 +184,6 @@ class Overview {
this.spaceGroupValue = this.element.querySelector('.space-group-value');
this.structTypeField= this.element.querySelector('.structure-type-field');
this.structTypeValue= this.element.querySelector('.structure-type-value');
this.structPrototypeField= this.element.querySelector('.structure-prototype-field');
this.structPrototypeValue= this.element.querySelector('.structure-prototype-value');
this.strukturberichtField= this.element.querySelector('.strukturbericht-field');
this.strukturberichtValue= this.element.querySelector('.strukturbericht-value');
//this.band_gap = this.element.getElementsByClassName('e-struct-field')[0];
//fields= this.element.getElementsByClassName('method-field');
......@@ -297,17 +284,12 @@ class Overview {
this.systemType.textContent= data.system_type;
this.structTypeField.style.display =
(isBulk && data.structure_type !== null ? 'block' : 'none');
this.structPrototypeField.style.display =
(isBulk && data.structure_prototype !== null ? 'block' : 'none');
this.strukturberichtField.style.display =
(isBulk && data.strukturbericht_designation !== null ? 'block' : 'none');
this.spaceGroupField.style.display = (isBulk ? 'block' : 'none');
if (isBulk){
this.structTypeValue.textContent= data.structure_type;
this.structPrototypeValue.textContent= data.structure_prototype;
this.strukturberichtValue.textContent= data.strukturbericht_designation;
this.spaceGroupValue.textContent = data.space_group_number;
this.spaceGroupValue.textContent = data.space_group_number+
' ('+data.space_group_international_short_symbol+')';
InfoSys.addElementToInfoSystem(this.spaceGroupValue,
'space-group.value:'+data.space_group_number);
}
......
......@@ -51,7 +51,7 @@ class StructureDetails extends DetailsViewBase {
<div class="footer-flex" style="display: none">
<div class="fields-container"
style="flex-basis: 60%; border-right: 1px solid #E4E4E4; ">
style="flex-basis: 70%; border-right: 1px solid #E4E4E4; ">
<div>
<b><span info-sys-data="crystal-system">Lattice</span></b>:
......@@ -67,7 +67,7 @@ class StructureDetails extends DetailsViewBase {
</div>
</div>
<div style="flex-basis: 40%; margin-left: 40px;">
<div style="flex-basis: 30%; margin-left: 30px;">
<div class="fields-container">
<div><b><span info-sys-data="wyckoff-position-population">Wyckoff sites</span></b></div>
<div class="wyckoff-sites-value"> </div>
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment