From c89c33a220b40c80f8b6d1b45d62d410b4da17d0 Mon Sep 17 00:00:00 2001
From: Thomas Purcell <purcell@fhi-berlin.mpg.de>
Date: Wed, 2 Sep 2020 17:11:31 +0200
Subject: [PATCH] Add error if feature list file is empty

should prevent seg fault kernel dead errors
---
 src/feature_creation/node/utils.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/feature_creation/node/utils.cpp b/src/feature_creation/node/utils.cpp
index f345d63e..3758794f 100644
--- a/src/feature_creation/node/utils.cpp
+++ b/src/feature_creation/node/utils.cpp
@@ -122,14 +122,15 @@ std::vector<node_ptr> str2node::phi_from_file(std::string filename, std::vector<
     std::ifstream file_stream;
     file_stream.open(filename, std::ios::in);
 
+    int numLines = 0;
     std::string line;
 
     std::vector<node_ptr> phi;
     int feat_ind = phi_0.size();
-    std::getline(file_stream, line);
 
     while(std::getline(file_stream, line))
     {
+        ++numLines;
         if(line[0] == '#')
             continue;
         try
@@ -148,6 +149,9 @@ std::vector<node_ptr> str2node::phi_from_file(std::string filename, std::vector<
         }
     }
     file_stream.close();
+
+    if(numLines < 1)
+        throw std::logic_error("File, " + filename + " not present");
     return phi;
 }
 
-- 
GitLab