nifty_gridder.cc 30.2 KB
Newer Older
Martin Reinecke's avatar
Martin Reinecke committed
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
/*
 *  This file is part of nifty_gridder.
 *
 *  nifty_gridder is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  nifty_gridder is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with nifty_fridder; if not, write to the Free Software
 *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 */

Martin Reinecke's avatar
Martin Reinecke committed
19
20
21
/* Copyright (C) 2019 Max-Planck-Society
   Author: Martin Reinecke */

Martin Reinecke's avatar
import  
Martin Reinecke committed
22
23
24
25
#include <pybind11/pybind11.h>
#include <pybind11/numpy.h>
#include <iostream>
#include <algorithm>
Martin Reinecke's avatar
Martin Reinecke committed
26
27

#define POCKETFFT_OPENMP
Martin Reinecke's avatar
updates    
Martin Reinecke committed
28
#include "pocketfft_hdronly.h"
Martin Reinecke's avatar
import  
Martin Reinecke committed
29

Martin Reinecke's avatar
tweaks    
Martin Reinecke committed
30
31
#ifdef __GNUC__
#define RESTRICT __restrict__
Martin Reinecke's avatar
Martin Reinecke committed
32
#define NOINLINE __attribute__ ((noinline))
Martin Reinecke's avatar
tweaks    
Martin Reinecke committed
33
34
35
36
#else
#define RESTRICT
#endif

Martin Reinecke's avatar
import  
Martin Reinecke committed
37
38
39
40
41
42
using namespace std;

namespace py = pybind11;

namespace {

Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
43
44
45
46
//
// basic utilities
//

47
48
49
50
51
52
void myassert(bool cond, const char *msg)
  {
  if (cond) return;
  throw runtime_error(msg);
  }

Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
53
54
55
56
57
58
59
60
61
62
63
/*! Returns the remainder of the division \a v1/v2.
    The result is non-negative.
    \a v1 can be positive or negative; \a v2 must be positive. */
template<typename T> inline T fmodulo (T v1, T v2)
  {
  if (v1>=0)
    return (v1<v2) ? v1 : fmod(v1,v2);
  T tmp=fmod(v1,v2)+v2;
  return (tmp==v2) ? T(0) : tmp;
  }

Martin Reinecke's avatar
Martin Reinecke committed
64
65
66
67
//
// Utilities for Gauss-Legendre quadrature
//

Martin Reinecke's avatar
Martin Reinecke committed
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
static inline double one_minus_x2 (double x)
  { return (fabs(x)>0.1) ? (1.+x)*(1.-x) : 1.-x*x; }

void legendre_prep(int n, vector<double> &x, vector<double> &w)
  {
  constexpr double pi = 3.141592653589793238462643383279502884197;
  constexpr double eps = 3e-14;
  int m = (n+1)>>1;
  x.resize(m);
  w.resize(m);

  double t0 = 1 - (1-1./n) / (8.*n*n);
  double t1 = 1./(4.*n+2.);

#pragma omp parallel
{
  int i;
#pragma omp for schedule(dynamic,100)
  for (i=1; i<=m; ++i)
    {
    double x0 = cos(pi * ((i<<2)-1) * t1) * t0;

    int dobreak=0;
    int j=0;
    double dpdx;
    while(1)
      {
      double P_1 = 1.0;
      double P0 = x0;
      double dx, x1;

      for (int k=2; k<=n; k++)
        {
        double P_2 = P_1;
        P_1 = P0;
//        P0 = ((2*k-1)*x0*P_1-(k-1)*P_2)/k;
        P0 = x0*P_1 + (k-1.)/k * (x0*P_1-P_2);
        }

      dpdx = (P_1 - x0*P0) * n / one_minus_x2(x0);

      /* Newton step */
      x1 = x0 - P0/dpdx;
      dx = x0-x1;
      x0 = x1;
      if (dobreak) break;

      if (abs(dx)<=eps) dobreak=1;
      if (++j>=100) throw runtime_error("convergence problem");
      }

    x[m-i] = x0;
    w[m-i] = 2. / (one_minus_x2(x0) * dpdx * dpdx);
    }
} // end of parallel region
  }

Martin Reinecke's avatar
Martin Reinecke committed
125
126
127
128
//
// Start of real gridder functionality
//

129
130
131
132
template<typename T>
  using pyarr = py::array_t<T>;
template<typename T>
  using pyarr_c = py::array_t<T, py::array::c_style | py::array::forcecast>;
Martin Reinecke's avatar
import  
Martin Reinecke committed
133

Martin Reinecke's avatar
merge    
Martin Reinecke committed
134
template<typename T> pyarr_c<T> makeArray(const vector<size_t> &shape)
Martin Reinecke's avatar
updates    
Martin Reinecke committed
135
136
  { return pyarr_c<T>(shape); }

Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
137
size_t get_w(double epsilon)
Martin Reinecke's avatar
Martin Reinecke committed
138
139
140
141
142
143
144
145
146
147
148
  {
  static const vector<double> maxmaperr { 1e8, 0.32, 0.021, 6.2e-4,
    1.08e-5, 1.25e-7, 8.25e-10, 5.70e-12, 1.22e-13, 2.48e-15, 4.82e-17,
    6.74e-19, 5.41e-21, 4.41e-23, 7.88e-25, 3.9e-26 };

  double epssq = epsilon*epsilon;

  for (size_t i=1; i<maxmaperr.size(); ++i)
    if (epssq>maxmaperr[i]) return i;
  throw runtime_error("requested epsilon too small - minimum is 2e-13");
  }
Martin Reinecke's avatar
Martin Reinecke committed
149

Martin Reinecke's avatar
merge    
Martin Reinecke committed
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
void checkArray(const py::array &arr, const char *aname,
  const vector<size_t> &shape)
  {
  if (size_t(arr.ndim())!=shape.size())
    {
    cerr << "Array '" << aname << "' has " << arr.ndim() << " dimensions; "
            "expected " << shape.size() << endl;
    throw runtime_error("bad dimensionality");
    }
  for (size_t i=0; i<shape.size(); ++i)
    if ((shape[i]!=0) && (size_t(arr.shape(i))!=shape[i]))
      {
      cerr << "Dimension " << i << " of array '" << aname << "' has size "
           << arr.shape(i) << "; expected " << shape[i] << endl;
      throw runtime_error("bad array size");
      }
  }

template<typename T> pyarr_c<T> provideArray(py::object &in,
  const vector<size_t> &shape)
  {
  if (in.is(py::none()))
    {
    auto tmp_ = makeArray<T>(shape);
    size_t sz = size_t(tmp_.size());
    auto tmp = tmp_.mutable_data();
    for (size_t i=0; i<sz; ++i)
      tmp[i] = T(0);
    return tmp_;
    }
  auto tmp_ = in.cast<pyarr_c<T>>();
  checkArray(tmp_, "temporary", shape);
  return tmp_;
  }

Martin Reinecke's avatar
Martin Reinecke committed
185
186
template<typename T> pyarr_c<T> complex2hartley
  (const pyarr_c<complex<T>> &grid_)
Martin Reinecke's avatar
Martin Reinecke committed
187
  {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
188
  checkArray(grid_, "grid", {0,0});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
189
  size_t nu = size_t(grid_.shape(0)), nv = size_t(grid_.shape(1));
Martin Reinecke's avatar
Martin Reinecke committed
190
191
  auto grid = grid_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
192
  auto res = makeArray<T>({nu,nv});
Martin Reinecke's avatar
Martin Reinecke committed
193
  auto grid2 = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
194
#pragma omp parallel for
Martin Reinecke's avatar
updates    
Martin Reinecke committed
195
  for (size_t u=0; u<nu; ++u)
Martin Reinecke's avatar
Martin Reinecke committed
196
    {
Martin Reinecke's avatar
updates    
Martin Reinecke committed
197
198
    size_t xu = (u==0) ? 0 : nu-u;
    for (size_t v=0; v<nv; ++v)
Martin Reinecke's avatar
Martin Reinecke committed
199
      {
Martin Reinecke's avatar
updates    
Martin Reinecke committed
200
201
202
      size_t xv = (v==0) ? 0 : nv-v;
      size_t i1 = u*nv+v;
      size_t i2 = xu*nv+xv;
Martin Reinecke's avatar
Martin Reinecke committed
203
204
      grid2[i1] = T(0.5)*(grid[i1].real()+grid[i1].imag()+
                          grid[i2].real()-grid[i2].imag());
Martin Reinecke's avatar
Martin Reinecke committed
205
206
207
208
209
      }
    }
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
210
211
template<typename T> pyarr_c<complex<T>> hartley2complex
  (const pyarr_c<T> &grid_)
Martin Reinecke's avatar
Martin Reinecke committed
212
  {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
213
  checkArray(grid_, "grid", {0, 0});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
214
  size_t nu = size_t(grid_.shape(0)), nv = size_t(grid_.shape(1));
Martin Reinecke's avatar
Martin Reinecke committed
215
216
  auto grid = grid_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
217
  auto res=makeArray<complex<T>>({nu, nv});
Martin Reinecke's avatar
Martin Reinecke committed
218
  auto grid2 = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
219
#pragma omp parallel for
Martin Reinecke's avatar
updates    
Martin Reinecke committed
220
  for (size_t u=0; u<nu; ++u)
Martin Reinecke's avatar
Martin Reinecke committed
221
    {
Martin Reinecke's avatar
updates    
Martin Reinecke committed
222
223
    size_t xu = (u==0) ? 0 : nu-u;
    for (size_t v=0; v<nv; ++v)
Martin Reinecke's avatar
Martin Reinecke committed
224
      {
Martin Reinecke's avatar
updates    
Martin Reinecke committed
225
226
227
      size_t xv = (v==0) ? 0 : nv-v;
      size_t i1 = u*nv+v;
      size_t i2 = xu*nv+xv;
Martin Reinecke's avatar
Martin Reinecke committed
228
229
230
      T v1 = T(0.5)*grid[i1];
      T v2 = T(0.5)*grid[i2];
      grid2[i1] = complex<T>(v1+v2, v1-v2);
Martin Reinecke's avatar
Martin Reinecke committed
231
232
233
234
235
      }
    }
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
236
237
238
239
240
241
242
243
template<typename T> void hartley2_2D(const pyarr_c<T> &in, pyarr_c<T> &out)
  {
  size_t nu=in.shape(0), nv=in.shape(1);
  pocketfft::r2r_hartley({nu, nv},
    {in.strides(0), in.strides(1)},
    {out.strides(0), out.strides(1)}, {0,1},
    in.data(), out.mutable_data(), T(1), 0);
  auto ptmp = out.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
244
#pragma omp parallel for
Martin Reinecke's avatar
Martin Reinecke committed
245
246
247
248
249
250
251
252
253
254
255
256
257
258
  for(size_t i=1; i<(nu+1)/2; ++i)
    for(size_t j=1; j<(nv+1)/2; ++j)
       {
       T a = ptmp[i*nv+j];
       T b = ptmp[(nu-i)*nv+j];
       T c = ptmp[i*nv+nv-j];
       T d = ptmp[(nu-i)*nv+nv-j];
       ptmp[i*nv+j] = T(0.5)*(a+b+c-d);
       ptmp[(nu-i)*nv+j] = T(0.5)*(a+b+d-c);
       ptmp[i*nv+nv-j] = T(0.5)*(a+c+d-b);
       ptmp[(nu-i)*nv+nv-j] = T(0.5)*(b+c+d-a);
       }
  }

Martin Reinecke's avatar
Martin Reinecke committed
259
260
/* Compute correction factors for the ES gridding kernel
   This implementation follows eqs. (3.8) to (3.10) of Barnett et al. 2018 */
Martin Reinecke's avatar
updates    
Martin Reinecke committed
261
vector<double> correction_factors (size_t n, size_t nval, size_t w)
Martin Reinecke's avatar
Martin Reinecke committed
262
263
264
265
266
267
268
269
270
271
  {
  constexpr double pi = 3.141592653589793238462643383279502884197;
  auto beta = 2.3*w;
  auto p = int(1.5*w+2);
  double alpha = pi*w/n;
  vector<double> x, wgt;
  legendre_prep(2*p,x,wgt);
  auto psi = x;
  for (auto &v:psi)
    v = exp(beta*(sqrt(1-v*v)-1.));
Martin Reinecke's avatar
updates    
Martin Reinecke committed
272
  vector<double> res(nval);
Martin Reinecke's avatar
Martin Reinecke committed
273
#pragma omp parallel for schedule(static)
Martin Reinecke's avatar
Martin Reinecke committed
274
275
276
277
278
  for (size_t k=0; k<nval; ++k)
    {
    double tmp=0;
    for (int i=0; i<p; ++i)
      tmp += wgt[i]*psi[i]*cos(alpha*k*x[i]);
Martin Reinecke's avatar
updates    
Martin Reinecke committed
279
    res[k] = 1./(w*tmp);
Martin Reinecke's avatar
Martin Reinecke committed
280
281
282
283
    }
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
284
template<typename T> struct UVW
Martin Reinecke's avatar
updates    
Martin Reinecke committed
285
  {
Martin Reinecke's avatar
Martin Reinecke committed
286
  T u, v, w;
Martin Reinecke's avatar
updates    
Martin Reinecke committed
287
  UVW () {}
Martin Reinecke's avatar
Martin Reinecke committed
288
289
  UVW (T u_, T v_, T w_) : u(u_), v(v_), w(w_) {}
  UVW operator* (T fct) const
Martin Reinecke's avatar
updates    
Martin Reinecke committed
290
291
    { return UVW(u*fct, v*fct, w*fct); }
  };
Martin Reinecke's avatar
Martin Reinecke committed
292

Martin Reinecke's avatar
Martin Reinecke committed
293
template<typename T> class Baselines
Martin Reinecke's avatar
Martin Reinecke committed
294
295
  {
  private:
Martin Reinecke's avatar
Martin Reinecke committed
296
    vector<UVW<T>> coord;
297
    vector<T> xlambda;
Martin Reinecke's avatar
updates    
Martin Reinecke committed
298
    size_t nrows, nchan;
Martin Reinecke's avatar
Martin Reinecke committed
299
300

  public:
301
    Baselines(const pyarr_c<T> &coord_, const pyarr_c<T> &lambda_)
Martin Reinecke's avatar
Martin Reinecke committed
302
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
303
304
      checkArray(coord_, "coord", {0, 3});
      checkArray(lambda_, "lambda", {0});
Martin Reinecke's avatar
Martin Reinecke committed
305
      nrows = coord_.shape(0);
306
307
      nchan = lambda_.shape(0);
      xlambda.resize(nchan);
Martin Reinecke's avatar
updates    
Martin Reinecke committed
308
      for (size_t i=0; i<nchan; ++i)
309
        xlambda[i] = T(1)/lambda_.data()[i];
Martin Reinecke's avatar
Martin Reinecke committed
310
      coord.resize(nrows);
Martin Reinecke's avatar
updates    
Martin Reinecke committed
311
      auto cood = coord_.data();
Martin Reinecke's avatar
Martin Reinecke committed
312
      for (size_t i=0; i<coord.size(); ++i)
Martin Reinecke's avatar
Martin Reinecke committed
313
        coord[i] = UVW<T>(cood[3*i], cood[3*i+1], cood[3*i+2]);
314
      myassert(nrows*nchan<(size_t(1)<<32), "too many entries in MS");
Martin Reinecke's avatar
Martin Reinecke committed
315
316
      }

Martin Reinecke's avatar
Martin Reinecke committed
317
    UVW<T> effectiveCoord(uint32_t index) const
318
319
320
      {
      size_t irow = index/nchan;
      size_t ichan = index-nchan*irow;
321
      return coord[irow]*xlambda[ichan];
322
323
      }
    UVW<T> effectiveCoord(size_t irow, size_t ichan) const
324
      { return coord[irow]*xlambda[ichan]; }
Martin Reinecke's avatar
Martin Reinecke committed
325
    size_t Nrows() const { return nrows; }
Martin Reinecke's avatar
updates    
Martin Reinecke committed
326
327
    size_t Nchannels() const { return nchan; }

Martin Reinecke's avatar
Martin Reinecke committed
328
    template<typename T2> pyarr_c<T2> ms2vis(const pyarr_c<T2> &ms_,
Martin Reinecke's avatar
updates    
Martin Reinecke committed
329
330
      const pyarr_c<uint32_t> &idx_) const
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
331
332
      checkArray(idx_, "idx", {0});
      checkArray(ms_, "ms", {nrows, nchan});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
333
334
335
336
      size_t nvis = size_t(idx_.shape(0));
      auto idx = idx_.data();
      auto ms = ms_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
337
      auto res=makeArray<T2>({nvis});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
338
      auto vis = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
339
#pragma omp parallel for
Martin Reinecke's avatar
updates    
Martin Reinecke committed
340
      for (size_t i=0; i<nvis; ++i)
341
        vis[i] = ms[idx[i]];
Martin Reinecke's avatar
updates    
Martin Reinecke committed
342
343
344
      return res;
      }

Martin Reinecke's avatar
Martin Reinecke committed
345
    template<typename T2> pyarr_c<T2> vis2ms(const pyarr_c<T2> &vis_,
Martin Reinecke's avatar
merge    
Martin Reinecke committed
346
      const pyarr_c<uint32_t> &idx_, py::object &ms_in) const
Martin Reinecke's avatar
updates    
Martin Reinecke committed
347
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
348
      checkArray(vis_, "vis", {0});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
349
      size_t nvis = size_t(vis_.shape(0));
Martin Reinecke's avatar
merge    
Martin Reinecke committed
350
      checkArray(idx_, "idx", {nvis});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
351
352
353
      auto idx = idx_.data();
      auto vis = vis_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
354
      auto res = provideArray<T2>(ms_in, {nrows, nchan});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
355
      auto ms = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
356
#pragma omp parallel for
Martin Reinecke's avatar
updates    
Martin Reinecke committed
357
      for (size_t i=0; i<nvis; ++i)
358
        ms[idx[i]] = vis[i];
Martin Reinecke's avatar
updates    
Martin Reinecke committed
359
360
      return res;
      }
Martin Reinecke's avatar
Martin Reinecke committed
361
362
  };

Martin Reinecke's avatar
Martin Reinecke committed
363
364
constexpr int logsquare=4;

Martin Reinecke's avatar
Martin Reinecke committed
365
template<typename T> class GridderConfig
Martin Reinecke's avatar
Martin Reinecke committed
366
367
368
  {
  private:
    size_t nx_dirty, ny_dirty;
Martin Reinecke's avatar
Martin Reinecke committed
369
    T ucorr, vcorr;
Martin Reinecke's avatar
Martin Reinecke committed
370
    size_t w, nsafe, nu, nv;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
371
    T beta;
Martin Reinecke's avatar
Martin Reinecke committed
372
    vector<T> cfu, cfv;
Martin Reinecke's avatar
Martin Reinecke committed
373
374
375

  public:
    GridderConfig(size_t nxdirty, size_t nydirty, double epsilon,
Martin Reinecke's avatar
Martin Reinecke committed
376
      double fov_x, double fov_y)
Martin Reinecke's avatar
Martin Reinecke committed
377
      : nx_dirty(nxdirty), ny_dirty(nydirty),
Martin Reinecke's avatar
Martin Reinecke committed
378
        ucorr(1./fov_x), vcorr(1./fov_y),
Martin Reinecke's avatar
Martin Reinecke committed
379
380
        w(get_w(epsilon)), nsafe((w+1)/2),
        nu(max(2*nsafe,2*nx_dirty)), nv(max(2*nsafe,2*ny_dirty)),
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
381
        beta(2.3*w),
Martin Reinecke's avatar
updates    
Martin Reinecke committed
382
        cfu(nx_dirty), cfv(ny_dirty)
Martin Reinecke's avatar
Martin Reinecke committed
383
384
385
386
      {
      myassert((nx_dirty&1)==0, "nx_dirty must be even");
      myassert((ny_dirty&1)==0, "ny_dirty must be even");
      myassert(epsilon>0, "epsilon must be positive");
Martin Reinecke's avatar
Martin Reinecke committed
387
388
      myassert(fov_x>0, "fov_x must be positive");
      myassert(fov_y>0, "fov_y must be positive");
Martin Reinecke's avatar
updates    
Martin Reinecke committed
389
390
391
392
393
394
395
396
397
398
399

      auto tmp = correction_factors(nu, nx_dirty/2+1, w);
      cfu[nx_dirty/2]=tmp[0];
      cfu[0]=tmp[nx_dirty/2];
      for (size_t i=1; i<nx_dirty/2; ++i)
        cfu[nx_dirty/2-i] = cfu[nx_dirty/2+i] = tmp[i];
      tmp = correction_factors(nv, ny_dirty/2+1, w);
      cfv[ny_dirty/2]=tmp[0];
      cfv[0]=tmp[ny_dirty/2];
      for (size_t i=1; i<ny_dirty/2; ++i)
        cfv[ny_dirty/2-i] = cfv[ny_dirty/2+i] = tmp[i];
Martin Reinecke's avatar
Martin Reinecke committed
400
401
402
403
      }
    size_t Nu() const { return nu; }
    size_t Nv() const { return nv; }
    size_t W() const { return w; }
404
    size_t Nsafe() const { return nsafe; }
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
405
    T Beta() const { return beta; }
Martin Reinecke's avatar
Martin Reinecke committed
406
    pyarr_c<T> grid2dirty(const pyarr_c<T> &grid) const
Martin Reinecke's avatar
Martin Reinecke committed
407
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
408
409
      checkArray(grid, "grid", {nu, nv});
      auto tmp = makeArray<T>({nu, nv});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
410
      auto ptmp = tmp.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
411
      hartley2_2D<T>(grid, tmp);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
412
      auto res = makeArray<T>({nx_dirty, ny_dirty});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
413
414
415
416
417
418
419
420
421
422
      auto pout = res.mutable_data();
      for (size_t i=0; i<nx_dirty; ++i)
        for (size_t j=0; j<ny_dirty; ++j)
          {
          size_t i2 = nu-nx_dirty/2+i;
          if (i2>=nu) i2-=nu;
          size_t j2 = nv-ny_dirty/2+j;
          if (j2>=nv) j2-=nv;
          pout[ny_dirty*i + j] = ptmp[nv*i2+j2]*cfu[i]*cfv[j];
          }
Martin Reinecke's avatar
Martin Reinecke committed
423
424
      return res;
      }
425
426
    pyarr_c<complex<T>> grid2dirty_c(const pyarr_c<complex<T>> &grid) const
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
427
428
      checkArray(grid, "grid", {nu, nv});
      auto tmp = makeArray<complex<T>>({nu, nv});
429
430
431
432
      auto ptmp = tmp.mutable_data();
      pocketfft::c2c({nu,nv},{grid.strides(0),grid.strides(1)},
        {tmp.strides(0), tmp.strides(1)}, {0,1}, pocketfft::BACKWARD,
        grid.data(), tmp.mutable_data(), T(1), 0);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
433
      auto res = makeArray<complex<T>>({nx_dirty, ny_dirty});
434
435
436
437
438
439
440
441
442
443
444
445
      auto pout = res.mutable_data();
      for (size_t i=0; i<nx_dirty; ++i)
        for (size_t j=0; j<ny_dirty; ++j)
          {
          size_t i2 = nu-nx_dirty/2+i;
          if (i2>=nu) i2-=nu;
          size_t j2 = nv-ny_dirty/2+j;
          if (j2>=nv) j2-=nv;
          pout[ny_dirty*i + j] = ptmp[nv*i2+j2]*cfu[i]*cfv[j];
          }
      return res;
      }
Martin Reinecke's avatar
Martin Reinecke committed
446
    pyarr_c<T> dirty2grid(const pyarr_c<T> &dirty) const
Martin Reinecke's avatar
updates    
Martin Reinecke committed
447
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
448
      checkArray(dirty, "dirty", {nx_dirty, ny_dirty});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
449
      auto pdirty = dirty.data();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
450
      auto tmp = makeArray<T>({nu, nv});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
451
452
453
454
455
456
457
458
459
460
461
462
      auto ptmp = tmp.mutable_data();
      for (size_t i=0; i<nu*nv; ++i)
        ptmp[i] = 0.;
      for (size_t i=0; i<nx_dirty; ++i)
        for (size_t j=0; j<ny_dirty; ++j)
          {
          size_t i2 = nu-nx_dirty/2+i;
          if (i2>=nu) i2-=nu;
          size_t j2 = nv-ny_dirty/2+j;
          if (j2>=nv) j2-=nv;
          ptmp[nv*i2+j2] = pdirty[ny_dirty*i + j]*cfu[i]*cfv[j];
          }
Martin Reinecke's avatar
Martin Reinecke committed
463
      hartley2_2D<T>(tmp, tmp);
Martin Reinecke's avatar
updates    
Martin Reinecke committed
464
465
      return tmp;
      }
466
467
    pyarr_c<complex<T>> dirty2grid_c(const pyarr_c<complex<T>> &dirty) const
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
468
      checkArray(dirty, "dirty", {nx_dirty, ny_dirty});
469
      auto pdirty = dirty.data();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
470
      auto tmp = makeArray<complex<T>>({nu, nv});
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
      auto ptmp = tmp.mutable_data();
      for (size_t i=0; i<nu*nv; ++i)
        ptmp[i] = 0.;
      for (size_t i=0; i<nx_dirty; ++i)
        for (size_t j=0; j<ny_dirty; ++j)
          {
          size_t i2 = nu-nx_dirty/2+i;
          if (i2>=nu) i2-=nu;
          size_t j2 = nv-ny_dirty/2+j;
          if (j2>=nv) j2-=nv;
          ptmp[nv*i2+j2] = pdirty[ny_dirty*i + j]*cfu[i]*cfv[j];
          }
      pocketfft::c2c({nu,nv},{tmp.strides(0),tmp.strides(1)},
        {tmp.strides(0), tmp.strides(1)}, {0,1}, pocketfft::FORWARD,
        tmp.data(), tmp.mutable_data(), T(1), 0);
      return tmp;
      }
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
488
489
490
491
492
493
494
495
496
    inline void getpix(T u_in, T v_in, T &u, T &v, int &iu0, int &iv0) const
      {
      u=fmodulo(u_in*ucorr, T(1))*nu,
      iu0 = int(u-w*0.5 + 1 + nu) - nu;
      if (iu0+w>nu+nsafe) iu0 = nu+nsafe-w;
      v=fmodulo(v_in*vcorr, T(1))*nv;
      iv0 = int(v-w*0.5 + 1 + nv) - nv;
      if (iv0+w>nv+nsafe) iv0 = nv+nsafe-w;
      }
Martin Reinecke's avatar
Martin Reinecke committed
497
498
  };

Martin Reinecke's avatar
Martin Reinecke committed
499
template<typename T> class Helper
Martin Reinecke's avatar
import  
Martin Reinecke committed
500
  {
Martin Reinecke's avatar
Martin Reinecke committed
501
  private:
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
502
    const GridderConfig<T> &gconf;
Martin Reinecke's avatar
Martin Reinecke committed
503
504
    int nu, nv, nsafe, w;
    T beta;
Martin Reinecke's avatar
Martin Reinecke committed
505
506
    complex<T> *grid;
    bool write;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
507
    int su;
Martin Reinecke's avatar
Martin Reinecke committed
508
509
  public:
    int sv;
Martin Reinecke's avatar
Martin Reinecke committed
510
  private:
Martin Reinecke's avatar
Martin Reinecke committed
511
512
513
    int iu0, iv0; // start index of the current visibility
    int bu0, bv0; // start index of the current buffer

Martin Reinecke's avatar
Martin Reinecke committed
514
    vector<complex<T>> data;
Martin Reinecke's avatar
import  
Martin Reinecke committed
515

Martin Reinecke's avatar
Martin Reinecke committed
516
    void dump() const
Martin Reinecke's avatar
import  
Martin Reinecke committed
517
      {
Martin Reinecke's avatar
Martin Reinecke committed
518
      if (bu0<-nsafe) return; // nothing written into buffer yet
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
519

Martin Reinecke's avatar
merge    
Martin Reinecke committed
520
#pragma omp critical (gridder_writing_to_grid)
Martin Reinecke's avatar
import  
Martin Reinecke committed
521
{
Martin Reinecke's avatar
Martin Reinecke committed
522
523
524
      int idxu = (bu0+nu)%nu;
      int idxv0 = (bv0+nv)%nv;
      for (int iu=0; iu<su; ++iu)
Martin Reinecke's avatar
import  
Martin Reinecke committed
525
526
        {
        int idxv = idxv0;
Martin Reinecke's avatar
Martin Reinecke committed
527
        for (int iv=0; iv<sv; ++iv)
Martin Reinecke's avatar
import  
Martin Reinecke committed
528
          {
Martin Reinecke's avatar
Martin Reinecke committed
529
          grid[idxu*nv + idxv] += data[iu*sv + iv];
Martin Reinecke's avatar
import  
Martin Reinecke committed
530
531
532
533
534
535
536
537
538
          if (++idxv>=nv) idxv=0;
          }
        if (++idxu>=nu) idxu=0;
        }
}
      }

    void load()
      {
Martin Reinecke's avatar
Martin Reinecke committed
539
540
541
      int idxu = (bu0+nu)%nu;
      int idxv0 = (bv0+nv)%nv;
      for (int iu=0; iu<su; ++iu)
Martin Reinecke's avatar
import  
Martin Reinecke committed
542
543
        {
        int idxv = idxv0;
Martin Reinecke's avatar
Martin Reinecke committed
544
        for (int iv=0; iv<sv; ++iv)
Martin Reinecke's avatar
import  
Martin Reinecke committed
545
          {
Martin Reinecke's avatar
Martin Reinecke committed
546
          data[iu*sv + iv] = grid[idxu*nv + idxv];
Martin Reinecke's avatar
import  
Martin Reinecke committed
547
548
549
550
551
552
553
          if (++idxv>=nv) idxv=0;
          }
        if (++idxu>=nu) idxu=0;
        }
      }

  public:
Martin Reinecke's avatar
Martin Reinecke committed
554
555
    complex<T> *p0;
    vector<T> kernel;
Martin Reinecke's avatar
import  
Martin Reinecke committed
556

Martin Reinecke's avatar
Martin Reinecke committed
557
    Helper(const GridderConfig<T> &gconf_, const complex<T> *grid_, bool write_)
Martin Reinecke's avatar
Martin Reinecke committed
558
559
560
561
562
      : gconf(gconf_), nu(gconf.Nu()), nv(gconf.Nv()), nsafe(gconf.Nsafe()), w(gconf.W()),
        beta(gconf.Beta()),
        grid(const_cast<complex<T> *>(grid_)), write(write_),
        su(2*nsafe+(1<<logsquare)), sv(2*nsafe+(1<<logsquare)),
        bu0(-1000000), bv0(-1000000), data(su*sv,T(0)), kernel(2*w)
Martin Reinecke's avatar
Martin Reinecke committed
563
564
565
566
      {}
    ~Helper() { if (write) dump(); }

    void prep(T u_in, T v_in)
Martin Reinecke's avatar
import  
Martin Reinecke committed
567
      {
Martin Reinecke's avatar
Martin Reinecke committed
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
      T u, v;
      gconf.getpix(u_in, v_in, u, v, iu0, iv0);
      T xw=T(2)/w;
      auto x0 = xw*(iu0-u);
      auto y0 = xw*(iv0-v);
      for (int i=0; i<w; ++i)
        {
        auto x = x0+i*xw;
        kernel[i  ] = beta*sqrt(T(1)-x*x);
        auto y = y0+i*xw;
        kernel[i+w] = beta*sqrt(T(1)-y*y);
        }
      for (auto &k : kernel)
        k = exp(k);

      if ((iu0<bu0) || (iv0<bv0) || (iu0+w>bu0+su) || (iv0+w>bv0+sv))
Martin Reinecke's avatar
import  
Martin Reinecke committed
584
        {
Martin Reinecke's avatar
Martin Reinecke committed
585
        if (write) { dump(); fill(data.begin(), data.end(), T(0)); }
Martin Reinecke's avatar
Martin Reinecke committed
586
587
        bu0=((((iu0+nsafe)>>logsquare)<<logsquare))-nsafe;
        bv0=((((iv0+nsafe)>>logsquare)<<logsquare))-nsafe;
Martin Reinecke's avatar
Martin Reinecke committed
588
        if (!write) load();
Martin Reinecke's avatar
import  
Martin Reinecke committed
589
        }
Martin Reinecke's avatar
Martin Reinecke committed
590
      p0 = data.data() + sv*(iu0-bu0) + iv0-bv0;
Martin Reinecke's avatar
import  
Martin Reinecke committed
591
592
593
      }
  };

594
595
596
597
template<typename T> pyarr_c<complex<T>> vis2grid_c(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<complex<T>> &vis_)
  {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
598
599
600
  checkArray(vis_, "vis", {0});
  size_t nvis = size_t(vis_.shape(0));
  checkArray(idx_, "idx", {nvis});
601
602
603
604
  auto vis=vis_.data();
  auto idx = idx_.data();

  size_t nu=gconf.Nu(), nv=gconf.Nv();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
605
  auto res = makeArray<complex<T>>({nu, nv});
606
607
  auto grid = res.mutable_data();
  for (size_t i=0; i<nu*nv; ++i) grid[i] = 0.;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
608
609
  T beta = gconf.Beta();
  size_t w = gconf.W();
610
611
612

#pragma omp parallel
{
Martin Reinecke's avatar
Martin Reinecke committed
613
  Helper<T> hlp(gconf, grid, true);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
614
  T emb = exp(-2*beta);
615
  const T * RESTRICT ku = hlp.kernel.data();
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
616
  const T * RESTRICT kv = hlp.kernel.data()+w;
617
618
619
620
621
622

  // Loop over sampling points
#pragma omp for schedule(guided,100)
  for (size_t ipart=0; ipart<nvis; ++ipart)
    {
    UVW<T> coord = baselines.effectiveCoord(idx[ipart]);
Martin Reinecke's avatar
Martin Reinecke committed
623
    hlp.prep(coord.u, coord.v);
624
625
    auto * RESTRICT ptr = hlp.p0;
    auto v(vis[ipart]*emb);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
626
    for (size_t cu=0; cu<w; ++cu)
627
628
      {
      complex<T> tmp(v*ku[cu]);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
629
      for (size_t cv=0; cv<w; ++cv)
630
631
632
633
634
635
636
637
        ptr[cv] += tmp*kv[cv];
      ptr+=hlp.sv;
      }
    }
} // end of parallel region
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
638
template<typename T> pyarr_c<T> vis2grid(const Baselines<T> &baselines,
Martin Reinecke's avatar
Martin Reinecke committed
639
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
Martin Reinecke's avatar
Martin Reinecke committed
640
641
  const pyarr_c<complex<T>> &vis_)
  { return complex2hartley(vis2grid_c(baselines, gconf, idx_, vis_)); }
Martin Reinecke's avatar
updates    
Martin Reinecke committed
642

Martin Reinecke's avatar
merge    
Martin Reinecke committed
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
template<typename T> pyarr_c<complex<T>> ms2grid_c(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<complex<T>> &ms_)
  {
  auto nrows = baselines.Nrows();
  auto nchan = baselines.Nchannels();
  checkArray(ms_, "ms", {nrows, nchan});
  checkArray(idx_, "idx", {0});
  size_t nvis = size_t(idx_.shape(0));
  auto ms = ms_.data();
  auto idx = idx_.data();

  size_t nu=gconf.Nu(), nv=gconf.Nv();
  auto res = makeArray<complex<T>>({nu, nv});
  auto grid = res.mutable_data();
  for (size_t i=0; i<nu*nv; ++i) grid[i] = 0.;
  T beta = gconf.Beta();
  size_t w = gconf.W();

#pragma omp parallel
{
  Helper<T> hlp(gconf, grid, true);
  T emb = exp(-2*beta);
  const T * RESTRICT ku = hlp.kernel.data();
  const T * RESTRICT kv = hlp.kernel.data()+w;

  // Loop over sampling points
#pragma omp for schedule(guided,100)
  for (size_t ipart=0; ipart<nvis; ++ipart)
    {
    UVW<T> coord = baselines.effectiveCoord(idx[ipart]);
    hlp.prep(coord.u, coord.v);
    auto * RESTRICT ptr = hlp.p0;
    auto v(ms[idx[ipart]]*emb);
    for (size_t cu=0; cu<w; ++cu)
      {
      complex<T> tmp(v*ku[cu]);
      for (size_t cv=0; cv<w; ++cv)
        ptr[cv] += tmp*kv[cv];
      ptr+=hlp.sv;
      }
    }
} // end of parallel region
  return res;
  }

template<typename T> pyarr_c<T> ms2grid(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<complex<T>> &ms_)
  { return complex2hartley(ms2grid_c(baselines, gconf, idx_, ms_)); }

694
695
696
697
698
template<typename T> pyarr_c<complex<T>> grid2vis_c(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<complex<T>> &grid_)
  {
  size_t nu=gconf.Nu(), nv=gconf.Nv();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
699
  checkArray(idx_, "idx", {0});
700
  auto grid = grid_.data();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
701
  checkArray(grid_, "grid", {nu, nv});
702
703
704
  size_t nvis = size_t(idx_.shape(0));
  auto idx = idx_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
705
  auto res = makeArray<complex<T>>({nvis});
706
  auto vis = res.mutable_data();
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
707
708
  T beta = gconf.Beta();
  size_t w = gconf.W();
709
710
711
712

  // Loop over sampling points
#pragma omp parallel
{
Martin Reinecke's avatar
Martin Reinecke committed
713
  Helper<T> hlp(gconf, grid, false);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
714
  T emb = exp(-2*beta);
715
  const T * RESTRICT ku = hlp.kernel.data();
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
716
  const T * RESTRICT kv = hlp.kernel.data()+w;
717
718
719
720
721

#pragma omp for schedule(guided,100)
  for (size_t ipart=0; ipart<nvis; ++ipart)
    {
    UVW<T> coord = baselines.effectiveCoord(idx[ipart]);
Martin Reinecke's avatar
Martin Reinecke committed
722
    hlp.prep(coord.u, coord.v);
723
724
    complex<T> r = 0;
    auto * RESTRICT ptr = hlp.p0;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
725
    for (size_t cu=0; cu<w; ++cu)
726
727
      {
      complex<T> tmp(0);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
728
      for (size_t cv=0; cv<w; ++cv)
729
730
731
732
733
734
735
736
737
738
        tmp += ptr[cv] * kv[cv];
      r += tmp*ku[cu];
      ptr += hlp.sv;
      }
    vis[ipart] = r*emb;
    }
}
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
739
740
741
742
743
template<typename T> pyarr_c<complex<T>> grid2vis(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<T> &grid_)
  { return grid2vis_c(baselines, gconf, idx_, hartley2complex(grid_)); }

Martin Reinecke's avatar
merge    
Martin Reinecke committed
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
template<typename T> pyarr_c<complex<T>> grid2ms_c(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<complex<T>> &grid_, py::object &ms_in)
  {
  size_t nu=gconf.Nu(), nv=gconf.Nv();
  checkArray(idx_, "idx", {0});
  auto grid = grid_.data();
  checkArray(grid_, "grid", {nu, nv});
  size_t nvis = size_t(idx_.shape(0));
  auto idx = idx_.data();

  auto res = provideArray<complex<T>>(ms_in,
    {baselines.Nrows(), baselines.Nchannels()});
  auto ms = res.mutable_data();
  T beta = gconf.Beta();
  size_t w = gconf.W();

  // Loop over sampling points
#pragma omp parallel
{
  Helper<T> hlp(gconf, grid, false);
  T emb = exp(-2*beta);
  const T * RESTRICT ku = hlp.kernel.data();
  const T * RESTRICT kv = hlp.kernel.data()+w;

#pragma omp for schedule(guided,100)
  for (size_t ipart=0; ipart<nvis; ++ipart)
    {
    UVW<T> coord = baselines.effectiveCoord(idx[ipart]);
    hlp.prep(coord.u, coord.v);
    complex<T> r = 0;
    auto * RESTRICT ptr = hlp.p0;
    for (size_t cu=0; cu<w; ++cu)
      {
      complex<T> tmp(0);
      for (size_t cv=0; cv<w; ++cv)
        tmp += ptr[cv] * kv[cv];
      r += tmp*ku[cu];
      ptr += hlp.sv;
      }
    ms[idx[ipart]] += r*emb;
    }
}
  return res;
  }

template<typename T> pyarr_c<complex<T>> grid2ms(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<T> &grid_, py::object &ms_in)
  { return grid2ms_c(baselines, gconf, idx_, hartley2complex(grid_), ms_in); }

Martin Reinecke's avatar
Martin Reinecke committed
795
template<typename T> pyarr_c<uint32_t> getIndices(const Baselines<T> &baselines,
796
797
  const GridderConfig<T> &gconf, const pyarr_c<bool> &flags_, int chbegin,
  int chend, T wmin, T wmax)
Martin Reinecke's avatar
updates    
Martin Reinecke committed
798
  {
799
800
  size_t nrow=baselines.Nrows(),
         nchan=baselines.Nchannels(),
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
801
         nsafe=gconf.Nsafe();
802
803
  if (chbegin<0) chbegin=0;
  if (chend<0) chend=nchan;
Martin Reinecke's avatar
merge    
Martin Reinecke committed
804
  checkArray(flags_, "flags", {nrow, nchan});
805
806
807
808
  auto flags = flags_.data();
  constexpr int side=1<<logsquare;
  size_t nbu = (gconf.Nu()+1+side-1) >> logsquare,
         nbv = (gconf.Nv()+1+side-1) >> logsquare;
Martin Reinecke's avatar
Martin Reinecke committed
809
810
811
  vector<uint32_t> acc(nbu*nbv+1, 0);
  vector<uint32_t> tmp(nrow*(chend-chbegin));
  for (size_t irow=0, idx=0; irow<nrow; ++irow)
Martin Reinecke's avatar
bug fix    
Martin Reinecke committed
812
    for (int ichan=chbegin; ichan<chend; ++ichan)
Martin Reinecke's avatar
Martin Reinecke committed
813
      if (!flags[irow*nchan+ichan])
814
        {
815
        auto uvw = baselines.effectiveCoord(irow, ichan);
816
817
        if ((uvw.w>=wmin) && (uvw.w<wmax))
          {
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
818
819
820
821
822
          T u, v;
          int iu0, iv0;
          gconf.getpix(uvw.u, uvw.v, u, v, iu0, iv0);
          iu0 = (iu0+nsafe)>>logsquare;
          iv0 = (iv0+nsafe)>>logsquare;
Martin Reinecke's avatar
Martin Reinecke committed
823
          ++acc[nbv*iu0 + iv0 + 1];
Martin Reinecke's avatar
bug fix    
Martin Reinecke committed
824
          tmp[idx++] = nbv*iu0 + iv0;
825
826
          }
        }
Martin Reinecke's avatar
Martin Reinecke committed
827
828
829

  for (size_t i=1; i<acc.size(); ++i)
    acc[i] += acc[i-1];
Martin Reinecke's avatar
merge    
Martin Reinecke committed
830
  auto res = makeArray<uint32_t>({acc.back()});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
831
  auto iout = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
832
  for (size_t irow=0, idx=0; irow<nrow; ++irow)
Martin Reinecke's avatar
bug fix    
Martin Reinecke committed
833
    for (int ichan=chbegin; ichan<chend; ++ichan)
Martin Reinecke's avatar
Martin Reinecke committed
834
      if (!flags[irow*nchan+ichan])
Martin Reinecke's avatar
bug fix    
Martin Reinecke committed
835
836
837
838
839
        {
        auto uvw = baselines.effectiveCoord(irow, ichan);
        if ((uvw.w>=wmin) && (uvw.w<wmax))
          iout[acc[tmp[idx++]]++] = irow*nchan+ichan;
        }
Martin Reinecke's avatar
updates    
Martin Reinecke committed
840
841
842
843
844
845
846
847
  return res;
  }

const char *Baselines_DS = R"""(
Class storing UVW coordinates and channel information.

Parameters
==========
Martin Reinecke's avatar
Martin Reinecke committed
848
849
coord: np.array((nrows, 3), dtype=np.float)
    u, v and w coordinates for each row
850
851
lambda: np.array((nchannels,), dtype=np.float)
    wave length for each individual channel
Martin Reinecke's avatar
updates    
Martin Reinecke committed
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
)""";

const char *BL_ms2vis_DS = R"""(
Extracts visibility data from a measurement for the provided indices.

Parameters
==========
ms: np.array((nrows, nchannels), dtype=np.complex)
    the measurement set's visibility data
idx: np.array((nvis,), dtype=np.uint32)
    the indices to be extracted

Returns
=======
np.array((nvis,), dtype=np.complex)
    The visibility data for the index array
)""";

const char *BL_vis2ms_DS = R"""(
Martin Reinecke's avatar
Martin Reinecke committed
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
Produces a new MS with the provided visibilities set.

Parameters
==========
vis: np.array((nvis,), dtype=np.complex)
    The visibility data for the index array
idx: np.array((nvis,), dtype=np.uint32)
    the indices to be inserted

Returns
=======
np.array((nrows, nchannels), dtype=np.complex)
    the measurement set's visibility data (0 where not covered by idx)
)""";

Martin Reinecke's avatar
Martin Reinecke committed
886
887
888
889
890
891
892
893
894
895
896
897
const char *GridderConfig_DS = R"""(
Class storing information related to the gridding/degridding process.

Parameters
==========
nxdirty: int
    x resolution of the dirty image; must be even
nydirty: int
    y resolution of the dirty image; must be even
epsilon: float
    required accuracy for the gridding/degridding step
    Must be >= 2e-13.
Martin Reinecke's avatar
Martin Reinecke committed
898
899
900
901
fov_x: float
    Field of view in x direction (radians)
fov_y: float
    Field of view in y direction (radians)
Martin Reinecke's avatar
Martin Reinecke committed
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
)""";

const char *grid2dirty_DS = R"""(
Converts from UV grid to dirty image (FFT, cropping, correction)

Parameters
==========
grid: np.array((nu, nv), dtype=np.float64)
    gridded UV data

Returns
=======
nd.array((nxdirty, nydirty), dtype=np.float64)
    the dirty image
)""";

const char *dirty2grid_DS = R"""(
Converts from a dirty image to a UV grid (correction, padding, FFT)

Parameters
==========
dirty: nd.array((nxdirty, nydirty), dtype=np.float64)
    the dirty image

Returns
=======
np.array((nu, nv), dtype=np.float64)
    gridded UV data
)""";

const char *getIndices_DS = R"""(
Selects a subset of entries from a `Baselines` object.

Parameters
==========
baselines: Baselines
    the Baselines object
gconf: GridderConf
    the GridderConf object to be used with the returned indices.
    (used to optimize the ordering of the indices)
942
943
flags: np.array((nrows, nchannels), dtype=np.bool)
    "True" indicates that the value should not be used
Martin Reinecke's avatar
Martin Reinecke committed
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
chbegin: int
    first channel to use (-1: start with the first available channel)
chend: int
    one-past last channel to use (-1: one past the last available channel)
wmin: float
    only select entries with w>=wmin
wmax: float
    only select entries with w<wmax

Returns
=======
np.array((nvis,), dtype=np.uint32)
    the compressed indices for all entries which match the selected criteria
    and are not flagged.
)""";

const char *vis2grid_DS = R"""(
Grids visibilities onto a UV grid

Parameters
==========
baselines: Baselines
    the Baselines object
gconf: GridderConf
    the GridderConf object to be used
    (used to optimize the ordering of the indices)
idx: np.array((nvis,), dtype=np.uint32)
    the indices for the entries to be gridded
vis: np.array((nvis,), dtype=np.complex)
    The visibility data for the index array

Returns
=======
np.array((nu,nv), dtype=np.float64):
    the gridded visibilities (made real by making use of Hermitian symmetry)
)""";

const char *grid2vis_DS = R"""(
Degrids visibilities from a UV grid

Parameters
==========
baselines: Baselines
    the Baselines object
gconf: GridderConf
    the GridderConf object to be used
    (used to optimize the ordering of the indices)
idx: np.array((nvis,), dtype=np.uint32)
    the indices for the entries to be degridded
grid: np.array((nu,nv), dtype=np.float64):
    the gridded visibilities (made real by making use of Hermitian symmetry)
vis: np.array((nvis,), dtype=np.complex)
    The visibility data for the index array

Returns
=======
np.array((nvis,), dtype=np.complex)
    The degridded visibility data
)""";
Martin Reinecke's avatar
import  
Martin Reinecke committed
1003
1004
1005
1006
} // unnamed namespace

PYBIND11_MODULE(nifty_gridder, m)
  {
1007
1008
  using namespace pybind11::literals;

Martin Reinecke's avatar
Martin Reinecke committed
1009
  py::class_<Baselines<double>> (m, "Baselines", Baselines_DS)
1010
    .def(py::init<const pyarr_c<double> &, const pyarr_c<double> &>(),
1011
      "coord"_a, "lambda"_a)
Martin Reinecke's avatar
Martin Reinecke committed
1012
1013
    .def ("Nrows",&Baselines<double>::Nrows)
    .def ("Nchannels",&Baselines<double>::Nchannels)
Martin Reinecke's avatar
Martin Reinecke committed
1014
    .def ("ms2vis",&Baselines<double>::ms2vis<complex<double>>, BL_ms2vis_DS, "ms"_a, "idx"_a)
Martin Reinecke's avatar
merge    
Martin Reinecke committed
1015
    .def ("vis2ms",&Baselines<double>::vis2ms<complex<double>>, BL_vis2ms_DS, "vis"_a, "idx"_a, "ms_in"_a=py::none());
Martin Reinecke's avatar
Martin Reinecke committed
1016
  py::class_<GridderConfig<double>> (m, "GridderConfig", GridderConfig_DS)
1017
    .def(py::init<size_t, size_t, double, double, double>(),"nxdirty"_a,
Martin Reinecke's avatar
Martin Reinecke committed
1018
      "nydirty"_a, "epsilon"_a, "fov_x"_a, "fov_y"_a)
Martin Reinecke's avatar
Martin Reinecke committed
1019
1020
    .def("Nu", &GridderConfig<double>::Nu)
    .def("Nv", &GridderConfig<double>::Nv)
Martin Reinecke's avatar
Martin Reinecke committed
1021
    .def("grid2dirty", &GridderConfig<double>::grid2dirty, grid2dirty_DS, "grid"_a)
1022
1023
1024
    .def("grid2dirty_c", &GridderConfig<double>::grid2dirty_c, "grid"_a)
    .def("dirty2grid", &GridderConfig<double>::dirty2grid, dirty2grid_DS, "dirty"_a)
    .def("dirty2grid_c", &GridderConfig<double>::dirty2grid_c, "dirty"_a);
1025
1026
  m.def("getIndices", getIndices<double>, getIndices_DS, "baselines"_a, "gconf"_a,
    "flags"_a, "chbegin"_a=-1, "chend"_a=-1, "wmin"_a=-1e30, "wmax"_a=1e30);
Martin Reinecke's avatar
Martin Reinecke committed
1027
  m.def("vis2grid",&vis2grid<double>, vis2grid_DS, "baselines"_a, "gconf"_a, "idx"_a, "vis"_a);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
1028
  m.def("ms2grid",&ms2grid<double>, "baselines"_a, "gconf"_a, "idx"_a, "ms"_a);
Martin Reinecke's avatar
Martin Reinecke committed
1029
  m.def("grid2vis",&grid2vis<double>, grid2vis_DS, "baselines"_a, "gconf"_a, "idx"_a, "grid"_a);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
1030
  m.def("grid2ms",&grid2ms<double>, "baselines"_a, "gconf"_a, "idx"_a, "grid"_a, "ms_in"_a=py::none());
1031
  m.def("vis2grid_c",&vis2grid_c<double>, "baselines"_a, "gconf"_a, "idx"_a, "vis"_a);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
1032
  m.def("ms2grid_c",&ms2grid_c<double>, "baselines"_a, "gconf"_a, "idx"_a, "ms"_a);
1033
  m.def("grid2vis_c",&grid2vis_c<double>, "baselines"_a, "gconf"_a, "idx"_a, "grid"_a);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
1034
  m.def("grid2ms_c",&grid2ms_c<double>, "baselines"_a, "gconf"_a, "idx"_a, "grid"_a, "ms_in"_a=py::none());
Martin Reinecke's avatar
import  
Martin Reinecke committed
1035
  }