nifty_gridder.cc 32.8 KB
Newer Older
Martin Reinecke's avatar
Martin Reinecke committed
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
/*
 *  This file is part of nifty_gridder.
 *
 *  nifty_gridder is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  nifty_gridder is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with nifty_fridder; if not, write to the Free Software
 *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 */

Martin Reinecke's avatar
Martin Reinecke committed
19
20
21
/* Copyright (C) 2019 Max-Planck-Society
   Author: Martin Reinecke */

Martin Reinecke's avatar
import  
Martin Reinecke committed
22
23
24
25
#include <pybind11/pybind11.h>
#include <pybind11/numpy.h>
#include <iostream>
#include <algorithm>
Martin Reinecke's avatar
Martin Reinecke committed
26
27

#define POCKETFFT_OPENMP
Martin Reinecke's avatar
updates    
Martin Reinecke committed
28
#include "pocketfft_hdronly.h"
Martin Reinecke's avatar
import  
Martin Reinecke committed
29

Martin Reinecke's avatar
tweaks    
Martin Reinecke committed
30
31
#ifdef __GNUC__
#define RESTRICT __restrict__
Martin Reinecke's avatar
Martin Reinecke committed
32
#define NOINLINE __attribute__ ((noinline))
Martin Reinecke's avatar
tweaks    
Martin Reinecke committed
33
34
35
36
#else
#define RESTRICT
#endif

Martin Reinecke's avatar
import  
Martin Reinecke committed
37
38
39
40
41
42
using namespace std;

namespace py = pybind11;

namespace {

Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
43
44
45
46
//
// basic utilities
//

47
48
49
50
51
52
void myassert(bool cond, const char *msg)
  {
  if (cond) return;
  throw runtime_error(msg);
  }

Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
53
54
55
56
57
58
59
60
61
62
63
/*! Returns the remainder of the division \a v1/v2.
    The result is non-negative.
    \a v1 can be positive or negative; \a v2 must be positive. */
template<typename T> inline T fmodulo (T v1, T v2)
  {
  if (v1>=0)
    return (v1<v2) ? v1 : fmod(v1,v2);
  T tmp=fmod(v1,v2)+v2;
  return (tmp==v2) ? T(0) : tmp;
  }

Martin Reinecke's avatar
Martin Reinecke committed
64
65
66
67
//
// Utilities for Gauss-Legendre quadrature
//

Martin Reinecke's avatar
Martin Reinecke committed
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
static inline double one_minus_x2 (double x)
  { return (fabs(x)>0.1) ? (1.+x)*(1.-x) : 1.-x*x; }

void legendre_prep(int n, vector<double> &x, vector<double> &w)
  {
  constexpr double pi = 3.141592653589793238462643383279502884197;
  constexpr double eps = 3e-14;
  int m = (n+1)>>1;
  x.resize(m);
  w.resize(m);

  double t0 = 1 - (1-1./n) / (8.*n*n);
  double t1 = 1./(4.*n+2.);

#pragma omp parallel
{
  int i;
#pragma omp for schedule(dynamic,100)
  for (i=1; i<=m; ++i)
    {
    double x0 = cos(pi * ((i<<2)-1) * t1) * t0;

    int dobreak=0;
    int j=0;
    double dpdx;
    while(1)
      {
      double P_1 = 1.0;
      double P0 = x0;
      double dx, x1;

      for (int k=2; k<=n; k++)
        {
        double P_2 = P_1;
        P_1 = P0;
//        P0 = ((2*k-1)*x0*P_1-(k-1)*P_2)/k;
        P0 = x0*P_1 + (k-1.)/k * (x0*P_1-P_2);
        }

      dpdx = (P_1 - x0*P0) * n / one_minus_x2(x0);

      /* Newton step */
      x1 = x0 - P0/dpdx;
      dx = x0-x1;
      x0 = x1;
      if (dobreak) break;

      if (abs(dx)<=eps) dobreak=1;
      if (++j>=100) throw runtime_error("convergence problem");
      }

    x[m-i] = x0;
    w[m-i] = 2. / (one_minus_x2(x0) * dpdx * dpdx);
    }
} // end of parallel region
  }

Martin Reinecke's avatar
Martin Reinecke committed
125
126
127
128
//
// Start of real gridder functionality
//

129
130
131
132
template<typename T>
  using pyarr = py::array_t<T>;
template<typename T>
  using pyarr_c = py::array_t<T, py::array::c_style | py::array::forcecast>;
Martin Reinecke's avatar
import  
Martin Reinecke committed
133

Martin Reinecke's avatar
merge    
Martin Reinecke committed
134
template<typename T> pyarr_c<T> makeArray(const vector<size_t> &shape)
Martin Reinecke's avatar
updates    
Martin Reinecke committed
135
136
  { return pyarr_c<T>(shape); }

Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
137
size_t get_w(double epsilon)
Martin Reinecke's avatar
Martin Reinecke committed
138
139
140
141
142
143
144
145
146
147
148
  {
  static const vector<double> maxmaperr { 1e8, 0.32, 0.021, 6.2e-4,
    1.08e-5, 1.25e-7, 8.25e-10, 5.70e-12, 1.22e-13, 2.48e-15, 4.82e-17,
    6.74e-19, 5.41e-21, 4.41e-23, 7.88e-25, 3.9e-26 };

  double epssq = epsilon*epsilon;

  for (size_t i=1; i<maxmaperr.size(); ++i)
    if (epssq>maxmaperr[i]) return i;
  throw runtime_error("requested epsilon too small - minimum is 2e-13");
  }
Martin Reinecke's avatar
Martin Reinecke committed
149

Martin Reinecke's avatar
merge    
Martin Reinecke committed
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
void checkArray(const py::array &arr, const char *aname,
  const vector<size_t> &shape)
  {
  if (size_t(arr.ndim())!=shape.size())
    {
    cerr << "Array '" << aname << "' has " << arr.ndim() << " dimensions; "
            "expected " << shape.size() << endl;
    throw runtime_error("bad dimensionality");
    }
  for (size_t i=0; i<shape.size(); ++i)
    if ((shape[i]!=0) && (size_t(arr.shape(i))!=shape[i]))
      {
      cerr << "Dimension " << i << " of array '" << aname << "' has size "
           << arr.shape(i) << "; expected " << shape[i] << endl;
      throw runtime_error("bad array size");
      }
  }

template<typename T> pyarr_c<T> provideArray(py::object &in,
  const vector<size_t> &shape)
  {
  if (in.is(py::none()))
    {
    auto tmp_ = makeArray<T>(shape);
    size_t sz = size_t(tmp_.size());
    auto tmp = tmp_.mutable_data();
    for (size_t i=0; i<sz; ++i)
      tmp[i] = T(0);
    return tmp_;
    }
  auto tmp_ = in.cast<pyarr_c<T>>();
  checkArray(tmp_, "temporary", shape);
  return tmp_;
  }

Martin Reinecke's avatar
Martin Reinecke committed
185
186
template<typename T> pyarr_c<T> complex2hartley
  (const pyarr_c<complex<T>> &grid_)
Martin Reinecke's avatar
Martin Reinecke committed
187
  {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
188
  checkArray(grid_, "grid", {0,0});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
189
  size_t nu = size_t(grid_.shape(0)), nv = size_t(grid_.shape(1));
Martin Reinecke's avatar
Martin Reinecke committed
190
191
  auto grid = grid_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
192
  auto res = makeArray<T>({nu,nv});
Martin Reinecke's avatar
Martin Reinecke committed
193
  auto grid2 = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
194
195
  {
  py::gil_scoped_release release;
Martin Reinecke's avatar
Martin Reinecke committed
196
#pragma omp parallel for
Martin Reinecke's avatar
updates    
Martin Reinecke committed
197
  for (size_t u=0; u<nu; ++u)
Martin Reinecke's avatar
Martin Reinecke committed
198
    {
Martin Reinecke's avatar
updates    
Martin Reinecke committed
199
200
    size_t xu = (u==0) ? 0 : nu-u;
    for (size_t v=0; v<nv; ++v)
Martin Reinecke's avatar
Martin Reinecke committed
201
      {
Martin Reinecke's avatar
updates    
Martin Reinecke committed
202
203
204
      size_t xv = (v==0) ? 0 : nv-v;
      size_t i1 = u*nv+v;
      size_t i2 = xu*nv+xv;
Martin Reinecke's avatar
Martin Reinecke committed
205
206
      grid2[i1] = T(0.5)*(grid[i1].real()+grid[i1].imag()+
                          grid[i2].real()-grid[i2].imag());
Martin Reinecke's avatar
Martin Reinecke committed
207
208
      }
    }
Martin Reinecke's avatar
Martin Reinecke committed
209
  }
Martin Reinecke's avatar
Martin Reinecke committed
210
211
212
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
213
214
template<typename T> pyarr_c<complex<T>> hartley2complex
  (const pyarr_c<T> &grid_)
Martin Reinecke's avatar
Martin Reinecke committed
215
  {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
216
  checkArray(grid_, "grid", {0, 0});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
217
  size_t nu = size_t(grid_.shape(0)), nv = size_t(grid_.shape(1));
Martin Reinecke's avatar
Martin Reinecke committed
218
219
  auto grid = grid_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
220
  auto res=makeArray<complex<T>>({nu, nv});
Martin Reinecke's avatar
Martin Reinecke committed
221
  auto grid2 = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
222
223
  {
  py::gil_scoped_release release;
Martin Reinecke's avatar
Martin Reinecke committed
224
#pragma omp parallel for
Martin Reinecke's avatar
updates    
Martin Reinecke committed
225
  for (size_t u=0; u<nu; ++u)
Martin Reinecke's avatar
Martin Reinecke committed
226
    {
Martin Reinecke's avatar
updates    
Martin Reinecke committed
227
228
    size_t xu = (u==0) ? 0 : nu-u;
    for (size_t v=0; v<nv; ++v)
Martin Reinecke's avatar
Martin Reinecke committed
229
      {
Martin Reinecke's avatar
updates    
Martin Reinecke committed
230
231
232
      size_t xv = (v==0) ? 0 : nv-v;
      size_t i1 = u*nv+v;
      size_t i2 = xu*nv+xv;
Martin Reinecke's avatar
Martin Reinecke committed
233
234
235
      T v1 = T(0.5)*grid[i1];
      T v2 = T(0.5)*grid[i2];
      grid2[i1] = complex<T>(v1+v2, v1-v2);
Martin Reinecke's avatar
Martin Reinecke committed
236
237
      }
    }
Martin Reinecke's avatar
Martin Reinecke committed
238
  }
Martin Reinecke's avatar
Martin Reinecke committed
239
240
241
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
242
243
244
template<typename T> void hartley2_2D(const pyarr_c<T> &in, pyarr_c<T> &out)
  {
  size_t nu=in.shape(0), nv=in.shape(1);
Martin Reinecke's avatar
Martin Reinecke committed
245
246
247
  pocketfft::stride_t s_i{in.strides(0), in.strides(1)},
                      s_o{out.strides(0), out.strides(1)};
  auto d_i = in.data();
Martin Reinecke's avatar
Martin Reinecke committed
248
  auto ptmp = out.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
249
250
251
  {
  py::gil_scoped_release release;
  pocketfft::r2r_hartley({nu, nv}, s_i, s_o, {0,1}, d_i, ptmp, T(1), 0);
Martin Reinecke's avatar
Martin Reinecke committed
252
#pragma omp parallel for
Martin Reinecke's avatar
Martin Reinecke committed
253
254
255
256
257
258
259
260
261
262
263
264
265
  for(size_t i=1; i<(nu+1)/2; ++i)
    for(size_t j=1; j<(nv+1)/2; ++j)
       {
       T a = ptmp[i*nv+j];
       T b = ptmp[(nu-i)*nv+j];
       T c = ptmp[i*nv+nv-j];
       T d = ptmp[(nu-i)*nv+nv-j];
       ptmp[i*nv+j] = T(0.5)*(a+b+c-d);
       ptmp[(nu-i)*nv+j] = T(0.5)*(a+b+d-c);
       ptmp[i*nv+nv-j] = T(0.5)*(a+c+d-b);
       ptmp[(nu-i)*nv+nv-j] = T(0.5)*(b+c+d-a);
       }
  }
Martin Reinecke's avatar
Martin Reinecke committed
266
  }
Martin Reinecke's avatar
Martin Reinecke committed
267

Martin Reinecke's avatar
Martin Reinecke committed
268
269
/* Compute correction factors for the ES gridding kernel
   This implementation follows eqs. (3.8) to (3.10) of Barnett et al. 2018 */
Martin Reinecke's avatar
updates    
Martin Reinecke committed
270
vector<double> correction_factors (size_t n, size_t nval, size_t w)
Martin Reinecke's avatar
Martin Reinecke committed
271
272
273
274
275
276
277
278
279
280
  {
  constexpr double pi = 3.141592653589793238462643383279502884197;
  auto beta = 2.3*w;
  auto p = int(1.5*w+2);
  double alpha = pi*w/n;
  vector<double> x, wgt;
  legendre_prep(2*p,x,wgt);
  auto psi = x;
  for (auto &v:psi)
    v = exp(beta*(sqrt(1-v*v)-1.));
Martin Reinecke's avatar
updates    
Martin Reinecke committed
281
  vector<double> res(nval);
Martin Reinecke's avatar
Martin Reinecke committed
282
#pragma omp parallel for schedule(static)
Martin Reinecke's avatar
Martin Reinecke committed
283
284
285
286
287
  for (size_t k=0; k<nval; ++k)
    {
    double tmp=0;
    for (int i=0; i<p; ++i)
      tmp += wgt[i]*psi[i]*cos(alpha*k*x[i]);
Martin Reinecke's avatar
updates    
Martin Reinecke committed
288
    res[k] = 1./(w*tmp);
Martin Reinecke's avatar
Martin Reinecke committed
289
290
291
292
    }
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
293
template<typename T> struct UVW
Martin Reinecke's avatar
updates    
Martin Reinecke committed
294
  {
Martin Reinecke's avatar
Martin Reinecke committed
295
  T u, v, w;
Martin Reinecke's avatar
updates    
Martin Reinecke committed
296
  UVW () {}
Martin Reinecke's avatar
Martin Reinecke committed
297
298
  UVW (T u_, T v_, T w_) : u(u_), v(v_), w(w_) {}
  UVW operator* (T fct) const
Martin Reinecke's avatar
updates    
Martin Reinecke committed
299
300
    { return UVW(u*fct, v*fct, w*fct); }
  };
Martin Reinecke's avatar
Martin Reinecke committed
301

Martin Reinecke's avatar
Martin Reinecke committed
302
template<typename T> class Baselines
Martin Reinecke's avatar
Martin Reinecke committed
303
304
  {
  private:
Martin Reinecke's avatar
Martin Reinecke committed
305
    vector<UVW<T>> coord;
306
    vector<T> f_over_c;
Martin Reinecke's avatar
updates    
Martin Reinecke committed
307
    size_t nrows, nchan;
Martin Reinecke's avatar
Martin Reinecke committed
308
309

  public:
310
    Baselines(const pyarr_c<T> &coord_, const pyarr_c<T> &freq_)
Martin Reinecke's avatar
Martin Reinecke committed
311
      {
312
      constexpr double speedOfLight = 299792458.;
Martin Reinecke's avatar
merge    
Martin Reinecke committed
313
      checkArray(coord_, "coord", {0, 3});
314
      checkArray(freq_, "freq", {0});
Martin Reinecke's avatar
Martin Reinecke committed
315
      nrows = coord_.shape(0);
316
      nchan = freq_.shape(0);
Martin Reinecke's avatar
Martin Reinecke committed
317
318
319
320
321
      myassert(nrows*nchan<(size_t(1)<<32), "too many entries in MS");
      auto freq = freq_.data();
      auto cood = coord_.data();
      {
      py::gil_scoped_release release;
322
      f_over_c.resize(nchan);
Martin Reinecke's avatar
updates    
Martin Reinecke committed
323
      for (size_t i=0; i<nchan; ++i)
Martin Reinecke's avatar
Martin Reinecke committed
324
        f_over_c[i] = freq[i]/speedOfLight;
Martin Reinecke's avatar
Martin Reinecke committed
325
326
      coord.resize(nrows);
      for (size_t i=0; i<coord.size(); ++i)
Martin Reinecke's avatar
Martin Reinecke committed
327
        coord[i] = UVW<T>(cood[3*i], cood[3*i+1], cood[3*i+2]);
Martin Reinecke's avatar
Martin Reinecke committed
328
      }
Martin Reinecke's avatar
Martin Reinecke committed
329
330
      }

Martin Reinecke's avatar
Martin Reinecke committed
331
    UVW<T> effectiveCoord(uint32_t index) const
332
333
334
      {
      size_t irow = index/nchan;
      size_t ichan = index-nchan*irow;
335
      return coord[irow]*f_over_c[ichan];
336
337
      }
    UVW<T> effectiveCoord(size_t irow, size_t ichan) const
338
      { return coord[irow]*f_over_c[ichan]; }
Martin Reinecke's avatar
Martin Reinecke committed
339
    size_t Nrows() const { return nrows; }
Martin Reinecke's avatar
updates    
Martin Reinecke committed
340
341
    size_t Nchannels() const { return nchan; }

Martin Reinecke's avatar
Martin Reinecke committed
342
    template<typename T2> pyarr_c<T2> ms2vis(const pyarr_c<T2> &ms_,
Martin Reinecke's avatar
updates    
Martin Reinecke committed
343
344
      const pyarr_c<uint32_t> &idx_) const
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
345
346
      checkArray(idx_, "idx", {0});
      checkArray(ms_, "ms", {nrows, nchan});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
347
348
349
350
      size_t nvis = size_t(idx_.shape(0));
      auto idx = idx_.data();
      auto ms = ms_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
351
      auto res=makeArray<T2>({nvis});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
352
      auto vis = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
353
354
      {
      py::gil_scoped_release release;
Martin Reinecke's avatar
Martin Reinecke committed
355
#pragma omp parallel for
Martin Reinecke's avatar
updates    
Martin Reinecke committed
356
      for (size_t i=0; i<nvis; ++i)
357
        vis[i] = ms[idx[i]];
Martin Reinecke's avatar
Martin Reinecke committed
358
      }
Martin Reinecke's avatar
updates    
Martin Reinecke committed
359
360
361
      return res;
      }

Martin Reinecke's avatar
Martin Reinecke committed
362
    template<typename T2> pyarr_c<T2> vis2ms(const pyarr_c<T2> &vis_,
Martin Reinecke's avatar
merge    
Martin Reinecke committed
363
      const pyarr_c<uint32_t> &idx_, py::object &ms_in) const
Martin Reinecke's avatar
updates    
Martin Reinecke committed
364
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
365
      checkArray(vis_, "vis", {0});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
366
      size_t nvis = size_t(vis_.shape(0));
Martin Reinecke's avatar
merge    
Martin Reinecke committed
367
      checkArray(idx_, "idx", {nvis});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
368
369
370
      auto idx = idx_.data();
      auto vis = vis_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
371
      auto res = provideArray<T2>(ms_in, {nrows, nchan});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
372
      auto ms = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
373
374
      {
      py::gil_scoped_release release;
Martin Reinecke's avatar
Martin Reinecke committed
375
#pragma omp parallel for
Martin Reinecke's avatar
updates    
Martin Reinecke committed
376
      for (size_t i=0; i<nvis; ++i)
377
        ms[idx[i]] = vis[i];
Martin Reinecke's avatar
Martin Reinecke committed
378
      }
Martin Reinecke's avatar
updates    
Martin Reinecke committed
379
380
      return res;
      }
Martin Reinecke's avatar
Martin Reinecke committed
381
382
  };

Martin Reinecke's avatar
Martin Reinecke committed
383
384
constexpr int logsquare=4;

Martin Reinecke's avatar
Martin Reinecke committed
385
template<typename T> class GridderConfig
Martin Reinecke's avatar
Martin Reinecke committed
386
387
388
  {
  private:
    size_t nx_dirty, ny_dirty;
Martin Reinecke's avatar
Martin Reinecke committed
389
    double eps, psx, psy;
Martin Reinecke's avatar
Martin Reinecke committed
390
    size_t w, nsafe, nu, nv;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
391
    T beta;
Martin Reinecke's avatar
Martin Reinecke committed
392
    vector<T> cfu, cfv;
Martin Reinecke's avatar
Martin Reinecke committed
393
394
395

  public:
    GridderConfig(size_t nxdirty, size_t nydirty, double epsilon,
Martin Reinecke's avatar
Martin Reinecke committed
396
      double pixsize_x, double pixsize_y)
Martin Reinecke's avatar
Martin Reinecke committed
397
398
      : nx_dirty(nxdirty), ny_dirty(nydirty), eps(epsilon),
        psx(pixsize_x), psy(pixsize_y),
Martin Reinecke's avatar
Martin Reinecke committed
399
400
        w(get_w(epsilon)), nsafe((w+1)/2),
        nu(max(2*nsafe,2*nx_dirty)), nv(max(2*nsafe,2*ny_dirty)),
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
401
        beta(2.3*w),
Martin Reinecke's avatar
updates    
Martin Reinecke committed
402
        cfu(nx_dirty), cfv(ny_dirty)
Martin Reinecke's avatar
Martin Reinecke committed
403
      {
Martin Reinecke's avatar
Martin Reinecke committed
404
405
      {
      py::gil_scoped_release release;
Martin Reinecke's avatar
Martin Reinecke committed
406
407
408
      myassert((nx_dirty&1)==0, "nx_dirty must be even");
      myassert((ny_dirty&1)==0, "ny_dirty must be even");
      myassert(epsilon>0, "epsilon must be positive");
Martin Reinecke's avatar
Martin Reinecke committed
409
410
      myassert(pixsize_x>0, "pixsize_x must be positive");
      myassert(pixsize_y>0, "pixsize_y must be positive");
Martin Reinecke's avatar
updates    
Martin Reinecke committed
411
412
413
414
415
416
417
418
419
420
421

      auto tmp = correction_factors(nu, nx_dirty/2+1, w);
      cfu[nx_dirty/2]=tmp[0];
      cfu[0]=tmp[nx_dirty/2];
      for (size_t i=1; i<nx_dirty/2; ++i)
        cfu[nx_dirty/2-i] = cfu[nx_dirty/2+i] = tmp[i];
      tmp = correction_factors(nv, ny_dirty/2+1, w);
      cfv[ny_dirty/2]=tmp[0];
      cfv[0]=tmp[ny_dirty/2];
      for (size_t i=1; i<ny_dirty/2; ++i)
        cfv[ny_dirty/2-i] = cfv[ny_dirty/2+i] = tmp[i];
Martin Reinecke's avatar
Martin Reinecke committed
422
      }
Martin Reinecke's avatar
Martin Reinecke committed
423
      }
Martin Reinecke's avatar
Martin Reinecke committed
424
425
426
427
428
    size_t Nxdirty() const { return nx_dirty; }
    size_t Nydirty() const { return ny_dirty; }
    double Epsilon() const { return eps; }
    double Pixsize_x() const { return psx; }
    double Pixsize_y() const { return psy; }
Martin Reinecke's avatar
Martin Reinecke committed
429
430
431
    size_t Nu() const { return nu; }
    size_t Nv() const { return nv; }
    size_t W() const { return w; }
432
    size_t Nsafe() const { return nsafe; }
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
433
    T Beta() const { return beta; }
Martin Reinecke's avatar
Martin Reinecke committed
434
    pyarr_c<T> grid2dirty(const pyarr_c<T> &grid) const
Martin Reinecke's avatar
Martin Reinecke committed
435
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
436
437
      checkArray(grid, "grid", {nu, nv});
      auto tmp = makeArray<T>({nu, nv});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
438
      auto ptmp = tmp.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
439
      hartley2_2D<T>(grid, tmp);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
440
      auto res = makeArray<T>({nx_dirty, ny_dirty});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
441
      auto pout = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
442
443
      {
      py::gil_scoped_release release;
Martin Reinecke's avatar
updates    
Martin Reinecke committed
444
445
446
447
448
449
450
451
452
      for (size_t i=0; i<nx_dirty; ++i)
        for (size_t j=0; j<ny_dirty; ++j)
          {
          size_t i2 = nu-nx_dirty/2+i;
          if (i2>=nu) i2-=nu;
          size_t j2 = nv-ny_dirty/2+j;
          if (j2>=nv) j2-=nv;
          pout[ny_dirty*i + j] = ptmp[nv*i2+j2]*cfu[i]*cfv[j];
          }
Martin Reinecke's avatar
Martin Reinecke committed
453
      }
Martin Reinecke's avatar
Martin Reinecke committed
454
455
      return res;
      }
456
457
    pyarr_c<complex<T>> grid2dirty_c(const pyarr_c<complex<T>> &grid) const
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
458
459
      checkArray(grid, "grid", {nu, nv});
      auto tmp = makeArray<complex<T>>({nu, nv});
460
461
462
463
      auto ptmp = tmp.mutable_data();
      pocketfft::c2c({nu,nv},{grid.strides(0),grid.strides(1)},
        {tmp.strides(0), tmp.strides(1)}, {0,1}, pocketfft::BACKWARD,
        grid.data(), tmp.mutable_data(), T(1), 0);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
464
      auto res = makeArray<complex<T>>({nx_dirty, ny_dirty});
465
      auto pout = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
466
467
      {
      py::gil_scoped_release release;
468
469
470
471
472
473
474
475
476
      for (size_t i=0; i<nx_dirty; ++i)
        for (size_t j=0; j<ny_dirty; ++j)
          {
          size_t i2 = nu-nx_dirty/2+i;
          if (i2>=nu) i2-=nu;
          size_t j2 = nv-ny_dirty/2+j;
          if (j2>=nv) j2-=nv;
          pout[ny_dirty*i + j] = ptmp[nv*i2+j2]*cfu[i]*cfv[j];
          }
Martin Reinecke's avatar
Martin Reinecke committed
477
      }
478
479
      return res;
      }
Martin Reinecke's avatar
Martin Reinecke committed
480
    pyarr_c<T> dirty2grid(const pyarr_c<T> &dirty) const
Martin Reinecke's avatar
updates    
Martin Reinecke committed
481
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
482
      checkArray(dirty, "dirty", {nx_dirty, ny_dirty});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
483
      auto pdirty = dirty.data();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
484
      auto tmp = makeArray<T>({nu, nv});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
485
      auto ptmp = tmp.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
486
487
      {
      py::gil_scoped_release release;
Martin Reinecke's avatar
updates    
Martin Reinecke committed
488
489
490
491
492
493
494
495
496
497
498
      for (size_t i=0; i<nu*nv; ++i)
        ptmp[i] = 0.;
      for (size_t i=0; i<nx_dirty; ++i)
        for (size_t j=0; j<ny_dirty; ++j)
          {
          size_t i2 = nu-nx_dirty/2+i;
          if (i2>=nu) i2-=nu;
          size_t j2 = nv-ny_dirty/2+j;
          if (j2>=nv) j2-=nv;
          ptmp[nv*i2+j2] = pdirty[ny_dirty*i + j]*cfu[i]*cfv[j];
          }
Martin Reinecke's avatar
Martin Reinecke committed
499
      }
Martin Reinecke's avatar
Martin Reinecke committed
500
      hartley2_2D<T>(tmp, tmp);
Martin Reinecke's avatar
updates    
Martin Reinecke committed
501
502
      return tmp;
      }
503
504
    pyarr_c<complex<T>> dirty2grid_c(const pyarr_c<complex<T>> &dirty) const
      {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
505
      checkArray(dirty, "dirty", {nx_dirty, ny_dirty});
506
      auto pdirty = dirty.data();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
507
      auto tmp = makeArray<complex<T>>({nu, nv});
508
      auto ptmp = tmp.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
509
510
511
      pocketfft::stride_t strides{tmp.strides(0),tmp.strides(1)};
      {
      py::gil_scoped_release release;
512
513
514
515
516
517
518
519
520
521
522
      for (size_t i=0; i<nu*nv; ++i)
        ptmp[i] = 0.;
      for (size_t i=0; i<nx_dirty; ++i)
        for (size_t j=0; j<ny_dirty; ++j)
          {
          size_t i2 = nu-nx_dirty/2+i;
          if (i2>=nu) i2-=nu;
          size_t j2 = nv-ny_dirty/2+j;
          if (j2>=nv) j2-=nv;
          ptmp[nv*i2+j2] = pdirty[ny_dirty*i + j]*cfu[i]*cfv[j];
          }
Martin Reinecke's avatar
Martin Reinecke committed
523
524
525
      pocketfft::c2c({nu,nv}, strides, strides, {0,1}, pocketfft::FORWARD,
        ptmp, ptmp, T(1), 0);
      }
526
527
      return tmp;
      }
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
528
529
    inline void getpix(T u_in, T v_in, T &u, T &v, int &iu0, int &iv0) const
      {
Martin Reinecke's avatar
Martin Reinecke committed
530
      u=fmodulo(u_in*psx, T(1))*nu,
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
531
532
      iu0 = int(u-w*0.5 + 1 + nu) - nu;
      if (iu0+w>nu+nsafe) iu0 = nu+nsafe-w;
Martin Reinecke's avatar
Martin Reinecke committed
533
      v=fmodulo(v_in*psy, T(1))*nv;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
534
535
536
      iv0 = int(v-w*0.5 + 1 + nv) - nv;
      if (iv0+w>nv+nsafe) iv0 = nv+nsafe-w;
      }
Martin Reinecke's avatar
Martin Reinecke committed
537
538
  };

Martin Reinecke's avatar
Martin Reinecke committed
539
template<typename T> class Helper
Martin Reinecke's avatar
import  
Martin Reinecke committed
540
  {
Martin Reinecke's avatar
Martin Reinecke committed
541
  private:
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
542
    const GridderConfig<T> &gconf;
Martin Reinecke's avatar
Martin Reinecke committed
543
544
    int nu, nv, nsafe, w;
    T beta;
545
546
547
    const complex<T> *grid_r;
    complex<T> *grid_w;
    int su, sv;
Martin Reinecke's avatar
Martin Reinecke committed
548
549
550
    int iu0, iv0; // start index of the current visibility
    int bu0, bv0; // start index of the current buffer

551
    vector<complex<T>> rbuf, wbuf;
Martin Reinecke's avatar
import  
Martin Reinecke committed
552

Martin Reinecke's avatar
Martin Reinecke committed
553
    void dump() const
Martin Reinecke's avatar
import  
Martin Reinecke committed
554
      {
Martin Reinecke's avatar
Martin Reinecke committed
555
      if (bu0<-nsafe) return; // nothing written into buffer yet
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
556

Martin Reinecke's avatar
merge    
Martin Reinecke committed
557
#pragma omp critical (gridder_writing_to_grid)
Martin Reinecke's avatar
import  
Martin Reinecke committed
558
{
Martin Reinecke's avatar
Martin Reinecke committed
559
560
561
      int idxu = (bu0+nu)%nu;
      int idxv0 = (bv0+nv)%nv;
      for (int iu=0; iu<su; ++iu)
Martin Reinecke's avatar
import  
Martin Reinecke committed
562
563
        {
        int idxv = idxv0;
Martin Reinecke's avatar
Martin Reinecke committed
564
        for (int iv=0; iv<sv; ++iv)
Martin Reinecke's avatar
import  
Martin Reinecke committed
565
          {
566
          grid_w[idxu*nv + idxv] += wbuf[iu*sv + iv];
Martin Reinecke's avatar
import  
Martin Reinecke committed
567
568
569
570
571
572
573
574
575
          if (++idxv>=nv) idxv=0;
          }
        if (++idxu>=nu) idxu=0;
        }
}
      }

    void load()
      {
Martin Reinecke's avatar
Martin Reinecke committed
576
577
578
      int idxu = (bu0+nu)%nu;
      int idxv0 = (bv0+nv)%nv;
      for (int iu=0; iu<su; ++iu)
Martin Reinecke's avatar
import  
Martin Reinecke committed
579
580
        {
        int idxv = idxv0;
Martin Reinecke's avatar
Martin Reinecke committed
581
        for (int iv=0; iv<sv; ++iv)
Martin Reinecke's avatar
import  
Martin Reinecke committed
582
          {
583
          rbuf[iu*sv + iv] = grid_r[idxu*nv + idxv];
Martin Reinecke's avatar
import  
Martin Reinecke committed
584
585
586
587
588
589
590
          if (++idxv>=nv) idxv=0;
          }
        if (++idxu>=nu) idxu=0;
        }
      }

  public:
591
592
    const complex<T> *p0r;
    complex<T> *p0w;
Martin Reinecke's avatar
Martin Reinecke committed
593
    vector<T> kernel;
Martin Reinecke's avatar
import  
Martin Reinecke committed
594

595
596
597
598
    Helper(const GridderConfig<T> &gconf_, const complex<T> *grid_r_,
      complex<T> *grid_w_)
      : gconf(gconf_), nu(gconf.Nu()), nv(gconf.Nv()), nsafe(gconf.Nsafe()),
        w(gconf.W()), beta(gconf.Beta()), grid_r(grid_r_), grid_w(grid_w_),
Martin Reinecke's avatar
Martin Reinecke committed
599
        su(2*nsafe+(1<<logsquare)), sv(2*nsafe+(1<<logsquare)),
600
601
602
603
        bu0(-1000000), bv0(-1000000),
        rbuf(su*sv*(grid_r!=nullptr),T(0)),
        wbuf(su*sv*(grid_w!=nullptr),T(0)),
        kernel(2*w)
Martin Reinecke's avatar
Martin Reinecke committed
604
      {}
605
606
607
    ~Helper() { if (grid_w) dump(); }

    int lineJump() const { return sv; }
Martin Reinecke's avatar
Martin Reinecke committed
608
609

    void prep(T u_in, T v_in)
Martin Reinecke's avatar
import  
Martin Reinecke committed
610
      {
Martin Reinecke's avatar
Martin Reinecke committed
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
      T u, v;
      gconf.getpix(u_in, v_in, u, v, iu0, iv0);
      T xw=T(2)/w;
      auto x0 = xw*(iu0-u);
      auto y0 = xw*(iv0-v);
      for (int i=0; i<w; ++i)
        {
        auto x = x0+i*xw;
        kernel[i  ] = beta*sqrt(T(1)-x*x);
        auto y = y0+i*xw;
        kernel[i+w] = beta*sqrt(T(1)-y*y);
        }
      for (auto &k : kernel)
        k = exp(k);

      if ((iu0<bu0) || (iv0<bv0) || (iu0+w>bu0+su) || (iv0+w>bv0+sv))
Martin Reinecke's avatar
import  
Martin Reinecke committed
627
        {
628
        if (grid_w) { dump(); fill(wbuf.begin(), wbuf.end(), T(0)); }
Martin Reinecke's avatar
Martin Reinecke committed
629
630
        bu0=((((iu0+nsafe)>>logsquare)<<logsquare))-nsafe;
        bv0=((((iv0+nsafe)>>logsquare)<<logsquare))-nsafe;
631
        if (grid_r) load();
Martin Reinecke's avatar
import  
Martin Reinecke committed
632
        }
633
634
      p0r = rbuf.data() + sv*(iu0-bu0) + iv0-bv0;
      p0w = wbuf.data() + sv*(iu0-bu0) + iv0-bv0;
Martin Reinecke's avatar
import  
Martin Reinecke committed
635
636
637
      }
  };

Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
638
639
640
template<typename T> pyarr_c<complex<T>> vis2grid_c(
  const Baselines<T> &baselines, const GridderConfig<T> &gconf,
  const pyarr_c<uint32_t> &idx_, const pyarr_c<complex<T>> &vis_)
641
  {
Martin Reinecke's avatar
merge    
Martin Reinecke committed
642
643
644
  checkArray(vis_, "vis", {0});
  size_t nvis = size_t(vis_.shape(0));
  checkArray(idx_, "idx", {nvis});
645
646
647
648
  auto vis=vis_.data();
  auto idx = idx_.data();

  size_t nu=gconf.Nu(), nv=gconf.Nv();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
649
  auto res = makeArray<complex<T>>({nu, nv});
650
  auto grid = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
651
652
  {
  py::gil_scoped_release release;
653
  for (size_t i=0; i<nu*nv; ++i) grid[i] = 0.;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
654
655
  T beta = gconf.Beta();
  size_t w = gconf.W();
656
657
658

#pragma omp parallel
{
659
  Helper<T> hlp(gconf, nullptr, grid);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
660
  T emb = exp(-2*beta);
661
  int jump = hlp.lineJump();
662
  const T * RESTRICT ku = hlp.kernel.data();
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
663
  const T * RESTRICT kv = hlp.kernel.data()+w;
664
665
666
667
668
669

  // Loop over sampling points
#pragma omp for schedule(guided,100)
  for (size_t ipart=0; ipart<nvis; ++ipart)
    {
    UVW<T> coord = baselines.effectiveCoord(idx[ipart]);
Martin Reinecke's avatar
Martin Reinecke committed
670
    hlp.prep(coord.u, coord.v);
671
    auto * RESTRICT ptr = hlp.p0w;
672
    auto v(vis[ipart]*emb);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
673
    for (size_t cu=0; cu<w; ++cu)
674
675
      {
      complex<T> tmp(v*ku[cu]);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
676
      for (size_t cv=0; cv<w; ++cv)
677
        ptr[cv] += tmp*kv[cv];
678
      ptr+=jump;
679
680
681
      }
    }
} // end of parallel region
Martin Reinecke's avatar
Martin Reinecke committed
682
  }
683
684
685
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
686
template<typename T> pyarr_c<T> vis2grid(const Baselines<T> &baselines,
Martin Reinecke's avatar
Martin Reinecke committed
687
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
Martin Reinecke's avatar
Martin Reinecke committed
688
689
  const pyarr_c<complex<T>> &vis_)
  { return complex2hartley(vis2grid_c(baselines, gconf, idx_, vis_)); }
Martin Reinecke's avatar
updates    
Martin Reinecke committed
690

Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
691
692
693
template<typename T> pyarr_c<complex<T>> ms2grid_c(
  const Baselines<T> &baselines, const GridderConfig<T> &gconf,
  const pyarr_c<uint32_t> &idx_, const pyarr_c<complex<T>> &ms_)
Martin Reinecke's avatar
merge    
Martin Reinecke committed
694
695
696
697
698
699
700
701
702
703
704
705
  {
  auto nrows = baselines.Nrows();
  auto nchan = baselines.Nchannels();
  checkArray(ms_, "ms", {nrows, nchan});
  checkArray(idx_, "idx", {0});
  size_t nvis = size_t(idx_.shape(0));
  auto ms = ms_.data();
  auto idx = idx_.data();

  size_t nu=gconf.Nu(), nv=gconf.Nv();
  auto res = makeArray<complex<T>>({nu, nv});
  auto grid = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
706
707
  {
  py::gil_scoped_release release;
Martin Reinecke's avatar
merge    
Martin Reinecke committed
708
709
710
711
712
713
  for (size_t i=0; i<nu*nv; ++i) grid[i] = 0.;
  T beta = gconf.Beta();
  size_t w = gconf.W();

#pragma omp parallel
{
714
  Helper<T> hlp(gconf, nullptr, grid);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
715
  T emb = exp(-2*beta);
716
  int jump = hlp.lineJump();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
717
718
719
720
721
722
723
724
725
  const T * RESTRICT ku = hlp.kernel.data();
  const T * RESTRICT kv = hlp.kernel.data()+w;

  // Loop over sampling points
#pragma omp for schedule(guided,100)
  for (size_t ipart=0; ipart<nvis; ++ipart)
    {
    UVW<T> coord = baselines.effectiveCoord(idx[ipart]);
    hlp.prep(coord.u, coord.v);
726
    auto * RESTRICT ptr = hlp.p0w;
Martin Reinecke's avatar
merge    
Martin Reinecke committed
727
728
729
730
731
732
    auto v(ms[idx[ipart]]*emb);
    for (size_t cu=0; cu<w; ++cu)
      {
      complex<T> tmp(v*ku[cu]);
      for (size_t cv=0; cv<w; ++cv)
        ptr[cv] += tmp*kv[cv];
733
      ptr+=jump;
Martin Reinecke's avatar
merge    
Martin Reinecke committed
734
735
736
      }
    }
} // end of parallel region
Martin Reinecke's avatar
Martin Reinecke committed
737
  }
Martin Reinecke's avatar
merge    
Martin Reinecke committed
738
739
740
741
742
743
744
745
  return res;
  }

template<typename T> pyarr_c<T> ms2grid(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<complex<T>> &ms_)
  { return complex2hartley(ms2grid_c(baselines, gconf, idx_, ms_)); }

746
747
748
template<typename T> pyarr_c<complex<T>> grid2vis_c(
  const Baselines<T> &baselines, const GridderConfig<T> &gconf,
  const pyarr_c<uint32_t> &idx_, const pyarr_c<complex<T>> &grid_)
749
750
  {
  size_t nu=gconf.Nu(), nv=gconf.Nv();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
751
  checkArray(idx_, "idx", {0});
752
  auto grid = grid_.data();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
753
  checkArray(grid_, "grid", {nu, nv});
754
755
756
  size_t nvis = size_t(idx_.shape(0));
  auto idx = idx_.data();

Martin Reinecke's avatar
merge    
Martin Reinecke committed
757
  auto res = makeArray<complex<T>>({nvis});
758
  auto vis = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
759
760
  {
  py::gil_scoped_release release;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
761
762
  T beta = gconf.Beta();
  size_t w = gconf.W();
763
764
765
766

  // Loop over sampling points
#pragma omp parallel
{
767
  Helper<T> hlp(gconf, grid, nullptr);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
768
  T emb = exp(-2*beta);
769
  int jump = hlp.lineJump();
770
  const T * RESTRICT ku = hlp.kernel.data();
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
771
  const T * RESTRICT kv = hlp.kernel.data()+w;
772
773
774
775
776

#pragma omp for schedule(guided,100)
  for (size_t ipart=0; ipart<nvis; ++ipart)
    {
    UVW<T> coord = baselines.effectiveCoord(idx[ipart]);
Martin Reinecke's avatar
Martin Reinecke committed
777
    hlp.prep(coord.u, coord.v);
778
    complex<T> r = 0;
779
    const auto * RESTRICT ptr = hlp.p0r;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
780
    for (size_t cu=0; cu<w; ++cu)
781
782
      {
      complex<T> tmp(0);
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
783
      for (size_t cv=0; cv<w; ++cv)
784
785
        tmp += ptr[cv] * kv[cv];
      r += tmp*ku[cu];
786
      ptr += jump;
787
788
789
790
      }
    vis[ipart] = r*emb;
    }
}
Martin Reinecke's avatar
Martin Reinecke committed
791
  }
792
793
794
  return res;
  }

Martin Reinecke's avatar
Martin Reinecke committed
795
796
797
798
799
template<typename T> pyarr_c<complex<T>> grid2vis(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<T> &grid_)
  { return grid2vis_c(baselines, gconf, idx_, hartley2complex(grid_)); }

Martin Reinecke's avatar
merge    
Martin Reinecke committed
800
801
802
803
804
805
806
807
808
809
810
811
812
813
template<typename T> pyarr_c<complex<T>> grid2ms_c(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<complex<T>> &grid_, py::object &ms_in)
  {
  size_t nu=gconf.Nu(), nv=gconf.Nv();
  checkArray(idx_, "idx", {0});
  auto grid = grid_.data();
  checkArray(grid_, "grid", {nu, nv});
  size_t nvis = size_t(idx_.shape(0));
  auto idx = idx_.data();

  auto res = provideArray<complex<T>>(ms_in,
    {baselines.Nrows(), baselines.Nchannels()});
  auto ms = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
814
815
  {
  py::gil_scoped_release release;
Martin Reinecke's avatar
merge    
Martin Reinecke committed
816
817
818
819
820
821
  T beta = gconf.Beta();
  size_t w = gconf.W();

  // Loop over sampling points
#pragma omp parallel
{
822
  Helper<T> hlp(gconf, grid, nullptr);
Martin Reinecke's avatar
merge    
Martin Reinecke committed
823
  T emb = exp(-2*beta);
824
  int jump = hlp.lineJump();
Martin Reinecke's avatar
merge    
Martin Reinecke committed
825
826
827
828
829
830
831
832
833
  const T * RESTRICT ku = hlp.kernel.data();
  const T * RESTRICT kv = hlp.kernel.data()+w;

#pragma omp for schedule(guided,100)
  for (size_t ipart=0; ipart<nvis; ++ipart)
    {
    UVW<T> coord = baselines.effectiveCoord(idx[ipart]);
    hlp.prep(coord.u, coord.v);
    complex<T> r = 0;
834
    const auto * RESTRICT ptr = hlp.p0r;
Martin Reinecke's avatar
merge    
Martin Reinecke committed
835
836
837
838
839
840
    for (size_t cu=0; cu<w; ++cu)
      {
      complex<T> tmp(0);
      for (size_t cv=0; cv<w; ++cv)
        tmp += ptr[cv] * kv[cv];
      r += tmp*ku[cu];
841
      ptr += jump;
Martin Reinecke's avatar
merge    
Martin Reinecke committed
842
843
844
845
      }
    ms[idx[ipart]] += r*emb;
    }
}
Martin Reinecke's avatar
Martin Reinecke committed
846
  }
Martin Reinecke's avatar
merge    
Martin Reinecke committed
847
848
849
850
851
852
853
854
  return res;
  }

template<typename T> pyarr_c<complex<T>> grid2ms(const Baselines<T> &baselines,
  const GridderConfig<T> &gconf, const pyarr_c<uint32_t> &idx_,
  const pyarr_c<T> &grid_, py::object &ms_in)
  { return grid2ms_c(baselines, gconf, idx_, hartley2complex(grid_), ms_in); }

Martin Reinecke's avatar
Martin Reinecke committed
855
template<typename T> pyarr_c<uint32_t> getIndices(const Baselines<T> &baselines,
856
857
  const GridderConfig<T> &gconf, const pyarr_c<bool> &flags_, int chbegin,
  int chend, T wmin, T wmax)
Martin Reinecke's avatar
updates    
Martin Reinecke committed
858
  {
859
860
  size_t nrow=baselines.Nrows(),
         nchan=baselines.Nchannels(),
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
861
         nsafe=gconf.Nsafe();
862
863
  if (chbegin<0) chbegin=0;
  if (chend<0) chend=nchan;
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
864
865
866
  myassert(chend>chbegin, "empty channel range selected");
  myassert(chend<=int(nchan), "chend too large");
  myassert(wmax>wmin, "empty w range selected");
Martin Reinecke's avatar
merge    
Martin Reinecke committed
867
  checkArray(flags_, "flags", {nrow, nchan});
868
869
870
871
  auto flags = flags_.data();
  constexpr int side=1<<logsquare;
  size_t nbu = (gconf.Nu()+1+side-1) >> logsquare,
         nbv = (gconf.Nv()+1+side-1) >> logsquare;
Martin Reinecke's avatar
Martin Reinecke committed
872
873
  vector<uint32_t> acc(nbu*nbv+1, 0);
  vector<uint32_t> tmp(nrow*(chend-chbegin));
Martin Reinecke's avatar
Martin Reinecke committed
874
875
  {
  py::gil_scoped_release release;
Martin Reinecke's avatar
Martin Reinecke committed
876
  for (size_t irow=0, idx=0; irow<nrow; ++irow)
Martin Reinecke's avatar
bug fix    
Martin Reinecke committed
877
    for (int ichan=chbegin; ichan<chend; ++ichan)
Martin Reinecke's avatar
Martin Reinecke committed
878
      if (!flags[irow*nchan+ichan])
879
        {
880
        auto uvw = baselines.effectiveCoord(irow, ichan);
881
882
        if ((uvw.w>=wmin) && (uvw.w<wmax))
          {
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
883
884
885
886
887
          T u, v;
          int iu0, iv0;
          gconf.getpix(uvw.u, uvw.v, u, v, iu0, iv0);
          iu0 = (iu0+nsafe)>>logsquare;
          iv0 = (iv0+nsafe)>>logsquare;
Martin Reinecke's avatar
Martin Reinecke committed
888
          ++acc[nbv*iu0 + iv0 + 1];
Martin Reinecke's avatar
bug fix    
Martin Reinecke committed
889
          tmp[idx++] = nbv*iu0 + iv0;
890
891
          }
        }
Martin Reinecke's avatar
Martin Reinecke committed
892
893
894

  for (size_t i=1; i<acc.size(); ++i)
    acc[i] += acc[i-1];
Martin Reinecke's avatar
Martin Reinecke committed
895
  }
Martin Reinecke's avatar
merge    
Martin Reinecke committed
896
  auto res = makeArray<uint32_t>({acc.back()});
Martin Reinecke's avatar
updates    
Martin Reinecke committed
897
  auto iout = res.mutable_data();
Martin Reinecke's avatar
Martin Reinecke committed
898
899
  {
  py::gil_scoped_release release;
Martin Reinecke's avatar
Martin Reinecke committed
900
  for (size_t irow=0, idx=0; irow<nrow; ++irow)
Martin Reinecke's avatar
bug fix    
Martin Reinecke committed
901
    for (int ichan=chbegin; ichan<chend; ++ichan)
Martin Reinecke's avatar
Martin Reinecke committed
902
      if (!flags[irow*nchan+ichan])
Martin Reinecke's avatar
bug fix    
Martin Reinecke committed
903
904
905
906
907
        {
        auto uvw = baselines.effectiveCoord(irow, ichan);
        if ((uvw.w>=wmin) && (uvw.w<wmax))
          iout[acc[tmp[idx++]]++] = irow*nchan+ichan;
        }
Martin Reinecke's avatar
Martin Reinecke committed
908
  }
Martin Reinecke's avatar
updates    
Martin Reinecke committed
909
910
911
912
913
914
915
916
  return res;
  }

const char *Baselines_DS = R"""(
Class storing UVW coordinates and channel information.

Parameters
==========
Martin Reinecke's avatar
Martin Reinecke committed
917
918
coord: np.array((nrows, 3), dtype=np.float)
    u, v and w coordinates for each row
919
920
freq: np.array((nchannels,), dtype=np.float)
    frequency for each individual channel (in Hz)
Martin Reinecke's avatar
updates    
Martin Reinecke committed
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
)""";

const char *BL_ms2vis_DS = R"""(
Extracts visibility data from a measurement for the provided indices.

Parameters
==========
ms: np.array((nrows, nchannels), dtype=np.complex)
    the measurement set's visibility data
idx: np.array((nvis,), dtype=np.uint32)
    the indices to be extracted

Returns
=======
np.array((nvis,), dtype=np.complex)
    The visibility data for the index array
)""";

const char *BL_vis2ms_DS = R"""(
Martin Reinecke's avatar
Martin Reinecke committed
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
Produces a new MS with the provided visibilities set.

Parameters
==========
vis: np.array((nvis,), dtype=np.complex)
    The visibility data for the index array
idx: np.array((nvis,), dtype=np.uint32)
    the indices to be inserted

Returns
=======
np.array((nrows, nchannels), dtype=np.complex)
    the measurement set's visibility data (0 where not covered by idx)
)""";

Martin Reinecke's avatar
Martin Reinecke committed
955
956
957
958
959
960
961
962
963
964
965
966
const char *GridderConfig_DS = R"""(
Class storing information related to the gridding/degridding process.

Parameters
==========
nxdirty: int
    x resolution of the dirty image; must be even
nydirty: int
    y resolution of the dirty image; must be even
epsilon: float
    required accuracy for the gridding/degridding step
    Must be >= 2e-13.
Martin Reinecke's avatar
Martin Reinecke committed
967
968
969
970
pixsize_x: float
    Pixel size in x direction (radians)
pixsize_y: float
    Pixel size in y direction (radians)
Martin Reinecke's avatar
Martin Reinecke committed
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
)""";

const char *grid2dirty_DS = R"""(
Converts from UV grid to dirty image (FFT, cropping, correction)

Parameters
==========
grid: np.array((nu, nv), dtype=np.float64)
    gridded UV data

Returns
=======
nd.array((nxdirty, nydirty), dtype=np.float64)
    the dirty image
)""";

const char *dirty2grid_DS = R"""(
Converts from a dirty image to a UV grid (correction, padding, FFT)

Parameters
==========
dirty: nd.array((nxdirty, nydirty), dtype=np.float64)
    the dirty image

Returns
=======
np.array((nu, nv), dtype=np.float64)
    gridded UV data
)""";

const char *getIndices_DS = R"""(
Selects a subset of entries from a `Baselines` object.

Parameters
==========
baselines: Baselines
    the Baselines object
gconf: GridderConf
    the GridderConf object to be used with the returned indices.
    (used to optimize the ordering of the indices)
1011
1012
flags: np.array((nrows, nchannels), dtype=np.bool)
    "True" indicates that the value should not be used
Martin Reinecke's avatar
Martin Reinecke committed
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
chbegin: int
    first channel to use (-1: start with the first available channel)
chend: int
    one-past last channel to use (-1: one past the last available channel)
wmin: float
    only select entries with w>=wmin
wmax: float
    only select entries with w<wmax

Returns
=======
np.array((nvis,), dtype=np.uint32)
    the compressed indices for all entries which match the selected criteria
    and are not flagged.
)""";

const char *vis2grid_DS = R"""(
Grids visibilities onto a UV grid

Parameters
==========
baselines: Baselines
    the Baselines object
gconf: GridderConf
    the GridderConf object to be used
    (used to optimize the ordering of the indices)
idx: np.array((nvis,), dtype=np.uint32)
    the indices for the entries to be gridded
vis: np.array((nvis,), dtype=np.complex)
    The visibility data for the index array

Returns
=======
np.array((nu,nv), dtype=np.float64):
    the gridded visibilities (made real by making use of Hermitian symmetry)
)""";

const char *grid2vis_DS = R"""(
Degrids visibilities from a UV grid

Parameters
==========
baselines: Baselines
    the Baselines object
gconf: GridderConf
    the GridderConf object to be used
    (used to optimize the ordering of the indices)
idx: np.array((nvis,), dtype=np.uint32)
    the indices for the entries to be degridded
grid: np.array((nu,nv), dtype=np.float64):
    the gridded visibilities (made real by making use of Hermitian symmetry)
vis: np.array((nvis,), dtype=np.complex)
    The visibility data for the index array

Returns
=======
np.array((nvis,), dtype=np.complex)
    The degridded visibility data
)""";
Martin Reinecke's avatar
import  
Martin Reinecke committed
1072
1073
1074
1075
} // unnamed namespace

PYBIND11_MODULE(nifty_gridder, m)
  {
1076
1077
  using namespace pybind11::literals;

Martin Reinecke's avatar
Martin Reinecke committed
1078
  py::class_<Baselines<double>> (m, "Baselines", Baselines_DS)
1079
    .def(py::init<const pyarr_c<double> &, const pyarr_c<double> &>(),
1080
      "coord"_a, "freq"_a)
Martin Reinecke's avatar
Martin Reinecke committed
1081
1082
    .def ("Nrows",&Baselines<double>::Nrows)
    .def ("Nchannels",&Baselines<double>::Nchannels)
Martin Reinecke's avatar
cleanup    
Martin Reinecke committed
1083
1084
1085
1086
    .def ("ms2vis",&Baselines<double>::ms2vis<complex<double>>, BL_ms2vis_DS,
      "ms"_a, "idx"_a)
    .def ("vis2ms",&Baselines<double>::vis2ms<complex<double>>, BL_vis2ms_DS,
      "vis"_a, "idx"_a, "ms_in"_a=py::none());
Martin Reinecke's avatar
Martin Reinecke committed
1087
  py::class_<GridderConfig<double>> (m, "GridderConfig", GridderConfig_DS)
1088
    .def(py::init<size_t, size_t, double, double, double>(),"nxdirty"_a,