Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • N NIFTy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ift
  • NIFTy
  • Merge requests
  • !415

CorrelatedFieldMaker: offset parametrization in one place

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lukas Platz requested to merge concise_offset_parametrization into NIFTy_6 Mar 06, 2020
  • Overview 6
  • Commits 10
  • Pipelines 5
  • Changes 4

Hi @parras, @pfrank, @phaim,

in the CorrelatedFieldMaker as it stands at the moment, the offset from zero is parametrized in two separate places.

I propose to unify the offset parametrization into CorrelatedFieldMaker.make via the parameters offset_mean, offset_std_mean, offset_std_std.

While at it, modified the getting_started_3 demo (where the CF model is introduced first) to pass the parameters by name and with comments, giving the reader a chance to understand what is happening and providing a nice template for copying. Also, I renamed a few function parameters in CorrelatedFieldMaker in hope to make them more descriptive, but you might disagree with my judgement there.

As the creators of the model, what do you think about these changes?

Cheers, Lukas

Edited Mar 31, 2020 by Lukas Platz
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: concise_offset_parametrization