NIFTy merge requestshttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests2022-05-10T11:47:25Zhttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/777Optimize KL plotting tweaks2022-05-10T11:47:25ZPhilipp Arrasparras@mpa-garching.mpg.deOptimize KL plotting tweaksMartin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/775Optimizekl fix2022-05-09T08:55:59ZPhilipp Arrasparras@mpa-garching.mpg.deOptimizekl fixLukas PlatzLukas Platzhttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/773Typo2022-05-03T08:53:22ZPhilipp Arrasparras@mpa-garching.mpg.deTypohttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/772LikelihoodChain: add missing scaling factor2022-04-29T11:34:28ZPhilipp Arrasparras@mpa-garching.mpg.deLikelihoodChain: add missing scaling factorMartin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/771Add convenience function to `Operator` to apply it to random samples2022-05-02T21:41:37ZLukas PlatzAdd convenience function to `Operator` to apply it to random samplesWhen developing generative models, one often needs to pass random samples through operator chains to evaluate their output.
To eliminate the need to type `op(ift.from_random(op.domain))` all the time, this MR adds the method `get_random...When developing generative models, one often needs to pass random samples through operator chains to evaluate their output.
To eliminate the need to type `op(ift.from_random(op.domain))` all the time, this MR adds the method `get_random_sample()` to `ift.operators.operator.Operator`. It implements the above given code without introducing import loops and passes keyword arguments through to the `from_random` call to make it as general as the reference code.
@parras @mtr What do you think about it? Do you have objections, also to the naming of the function? Is this functionality already present somehow?
Cheers!https://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/770sample mapping options2022-04-26T17:26:52ZDavid Outlandsample mapping optionsImplementation of sample mapping options for MetricKL() and for mean_value_and_grad(). Pre-implemented options selectable with string keys include jax.lax.map and jax.pmap, the latter for parallel mapping. Other mapping options beyond th...Implementation of sample mapping options for MetricKL() and for mean_value_and_grad(). Pre-implemented options selectable with string keys include jax.lax.map and jax.pmap, the latter for parallel mapping. Other mapping options beyond the pre-implemented ones can be directly passed as the corresponding function itself. Details on how to do this are provided in the documentation.Gordian EdenhoferGordian Edenhoferhttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/769Plot EnergyHistory in optimize_kl2022-05-03T07:24:32ZLukas PlatzPlot EnergyHistory in optimize_kl@parras What do you think of this?@parras What do you think of this?Martin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/768Fix broken EnergyHistory plotting2022-04-22T08:50:50ZLukas PlatzFix broken EnergyHistory plottingLine `593` expects `EnergyHistory` objects to be wrapped in a list, but line `580` did not ensure they are wrapped. Fixed this.
Also, for consistency
- added list wrapping to line `618`
- deleted de-wrapping in line `594`Line `593` expects `EnergyHistory` objects to be wrapped in a list, but line `580` did not ensure they are wrapped. Fixed this.
Also, for consistency
- added list wrapping to line `618`
- deleted de-wrapping in line `594`Philipp Arrasparras@mpa-garching.mpg.dePhilipp Arrasparras@mpa-garching.mpg.dehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/767Count likelihood evaluations2022-04-22T14:55:49ZPhilipp Arrasparras@mpa-garching.mpg.deCount likelihood evaluationsMartin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/766Port doc changes from NIFTy_7 to NIFTy_82022-04-12T14:05:05ZPhilipp Arrasparras@mpa-garching.mpg.dePort doc changes from NIFTy_7 to NIFTy_8Martin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/765New html docu2022-04-12T13:57:25ZPhilipp Arrasparras@mpa-garching.mpg.deNew html docuhttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/764Add references to correlated field literature2022-04-12T14:25:03ZPhilipp Arrasparras@mpa-garching.mpg.deAdd references to correlated field literatureMartin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/763exec_time: add ntries2022-04-08T12:59:56ZPhilipp Arrasparras@mpa-garching.mpg.deexec_time: add ntriesMartin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/762Fix BlockDiagonalOperator repr2022-04-08T09:25:40ZGordian EdenhoferFix BlockDiagonalOperator reprMartin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/761Restructure Docs2022-04-14T16:46:50ZVincent EberleRestructure DocsChanges in Readme
=================
I fixed some broken links, e.g.: the mpi4py link and one link the a code section on git were broken)
Changes in the generated docs
=============================
- how to generate the docs was stated...Changes in Readme
=================
I fixed some broken links, e.g.: the mpi4py link and one link the a code section on git were broken)
Changes in the generated docs
=============================
- how to generate the docs was stated twice (user/installation and dev/index) and once the dependencies were incomplete
- IMHO installation for developers should be part of dev-section (to keep it ease to find the installation guide I put in a link from installation to dec/index
- plotting, mpi4py, etc are also used by non developers, so I moved the section to the user installation
Further suggestions
===================
- [x] moving the section on installation of mpi4py and matplotlib in the README file as well
- [x] installation guide for astropy, h5py (or a link), in order to keep it the way we do it for other opt. dependencies
- [x] putting in or changing the developer section to the way most of us install nifty etc. (cloning repo, pip install --user -e .,) since also new group members use these instructions. (I think this would decrease some overhead)
@parras @mtr what do you think?Martin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/759Elbo pf2022-04-04T11:31:24ZPhilipp FrankElbo pfMatteo GuardianiMatteo Guardianihttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/758CFM: Deprecate complicated dofdex2022-04-12T12:59:22ZPhilipp Arrasparras@mpa-garching.mpg.deCFM: Deprecate complicated dofdex@pfrank @jroth As discussed previously.
This change will help to maintain the correlated field model. Note that no functionality is lost. If users want to use nontrivial dofdexes, they can instantiate the CorrelatedFieldModel multiple t...@pfrank @jroth As discussed previously.
This change will help to maintain the correlated field model. Note that no functionality is lost. If users want to use nontrivial dofdexes, they can instantiate the CorrelatedFieldModel multiple times.
My plan is to remove this deprecation warning and the advanced dofdex features in approx 2 months (if noone objects).
@mtr @veberle @gedenhof what do you think?https://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/757Restore matplotlib as optional dependency and improve `exec_time`2022-04-01T09:15:59ZPhilipp Arrasparras@mpa-garching.mpg.deRestore matplotlib as optional dependency and improve `exec_time`Martin ReineckeMartin Reineckehttps://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/756fix performance of adjoint linearization of cf model for total_n!=02022-04-05T13:19:28ZJakob Rothfix performance of adjoint linearization of cf model for total_n!=0https://gitlab.mpcdf.mpg.de/ift/nifty/-/merge_requests/753Minor improvements2022-03-23T23:03:05ZPhilipp Arrasparras@mpa-garching.mpg.deMinor improvements