Suggestion: Add dtype property to DomainTuple
I suggest to add a property called dtype
to DomainTuple
. When wrapping a numpy array as Field
the constructor would check that the dtype of the array and the DomainTuple
coincide. Functions like from_random
do not need to take a dtype any more. In particular, sampling from e.g. DiagonalOperator
s become unambiguous in terms of drawing either a real or a complex field. This in turn would simplify the KL because the lh_sampling_dtype
would disappear.
I am not 100% sure how to treat RGSpace.get_default_codomain()
. Would the default codomain of a real space be real again or complex? My suggestion is to add an optional argument to that function and take as default the same dtype as the original space.
Also I am not sure how to tell the DomainTuple
its dtype. I suggest as an additional argument of DomainTuple.make()
.