Commit dee5dfec authored by Martin Reinecke's avatar Martin Reinecke
Browse files

Merge branch 'fix_get_sqrt' into 'NIFTy_7'

Fixup get_sqrt()

See merge request !589
parents 3f47aec4 d5f2bff0
Pipeline #92054 passed with stages
in 24 minutes and 23 seconds
......@@ -167,7 +167,7 @@ class DiagonalOperator(EndomorphicOperator):
return self.process_sample(res, from_inverse)
def get_sqrt(self):
if not np.iscomplexobj(self._ldiag) or (self._ldiag < 0).any():
if np.iscomplexobj(self._ldiag) or (self._ldiag < 0).any():
raise ValueError("get_sqrt() works only for positive definite operators.")
return self._from_ldiag((), np.sqrt(self._ldiag))
......@@ -59,6 +59,8 @@ class SandwichOperator(EndomorphicOperator):
if not isinstance(bun, LinearOperator):
raise TypeError("bun must be a linear operator")
if isinstance(bun, ScalingOperator):
if cheese is None:
return bun @ bun
return cheese.scale(abs(bun._factor)**2)
if cheese is not None and not isinstance(cheese, LinearOperator):
raise TypeError("cheese must be a linear operator or None")
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# GNU General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <>.
# Copyright(C) 2020 Max-Planck-Society
# Author: Philipp Arras
# NIFTy is being developed at the Max-Planck-Institut fuer Astrophysik.
import pytest
import nifty7 as ift
from ..common import setup_function, teardown_function
pmp = pytest.mark.parametrize
dom = ift.RGSpace(5)
@pmp("inp", [(4., True), (-3., False), (2, True), (2.+0j, False), (1, True)])
@pmp("mode", [0, 1, 2])
def test_get_sqrt(inp, mode):
val, shouldwork = inp
fld = ift.full(dom, val)
if mode == 0:
op = ift.makeOp(fld)
elif mode == 1:
op = ift.makeOp(val, ift.makeDomain(dom))
elif mode == 2:
fft = ift.FFTOperator(dom)
if val == 1:
op = ift.SandwichOperator.make(fft)
cheese = ift.makeOp(ift.full(, val))
op = ift.SandwichOperator.make(fft, cheese=cheese)
if not shouldwork:
with pytest.raises(ValueError):
inp = ift.from_random(op.domain)
res0 = (op.get_sqrt().adjoint @ op.get_sqrt())(inp)
res1 = op(inp)
ift.extra.assert_allclose(res0, res1, rtol=1e-15)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment