ctapipe_io_magic merge requestshttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests2020-01-21T08:24:30Zhttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/1Removed the lines where pointing variables was trying to access ra and dec me...2020-01-21T08:24:30ZAlessio BertiRemoved the lines where pointing variables was trying to access ra and dec members.Closes issue #2.Closes issue #2.https://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/20Draft: update ctapipe_io_magic to use ctapipe v0.122021-12-14T21:12:13ZAlessio BertiDraft: update ctapipe_io_magic to use ctapipe v0.12Closes #13.Closes #13.ctapipe 0.12Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/19Update uproot42021-11-28T11:06:48ZAlessio BertiUpdate uproot4Update code to use uproot v4. Uproot 3 has been deprecated (see https://github.com/scikit-hep/uproot3)Update code to use uproot v4. Uproot 3 has been deprecated (see https://github.com/scikit-hep/uproot3)Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/18Use CameraDescription instead of CameraGeometry, as required by TelescopeDesc...2021-04-23T14:06:00ZAlessio BertiUse CameraDescription instead of CameraGeometry, as required by TelescopeDescription.We were still using `CameraGeometry` in the `TelescopeDescription`, but actually a `CameraDescription` is needed. This change will need also a simple change in `magic-cta-pipe` event_processing.py script.We were still using `CameraGeometry` in the `TelescopeDescription`, but actually a `CameraDescription` is needed. This change will need also a simple change in `magic-cta-pipe` event_processing.py script.Federico Di PierroFederico Di Pierrohttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/17Fixes for mono generator and use of relative paths2021-01-27T16:49:11ZAlessio BertiFixes for mono generator and use of relative pathsIn this merge request the following fixes are implemented:
- fix to return empty dictionaries/arrays in `load_events` for the telescope which is not selected when using `mono_event_generator`. The problem was that it was trying to use em...In this merge request the following fixes are implemented:
- fix to return empty dictionaries/arrays in `load_events` for the telescope which is not selected when using `mono_event_generator`. The problem was that it was trying to use empty arrays for the pointing interpolation (which is not needed anyway since no files are loaded for the not selected telescope)
- fix in `find_mono_events` when using `mono_event_generator`. The implementation was trying to use events from both telescopes, which is not possible when using this generator.
- fix to allow the usage of relative paths for `input_url`Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/16Dev aberti drive interpolation2021-01-15T10:04:18ZAlessio BertiDev aberti drive interpolationThis merge request deals with:
- issue #12, that is code was changed to speed up finding mono and stereo event IDs
- issue #11, which was causing crashes in `magic-cta-pipe`
See the issues for detailed explanation about the problems and ...This merge request deals with:
- issue #12, that is code was changed to speed up finding mono and stereo event IDs
- issue #11, which was causing crashes in `magic-cta-pipe`
See the issues for detailed explanation about the problems and their solution implemented in the code.
Closes #11, #12Federico Di PierroFederico Di Pierrohttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/15Solving a bug in MAGIC tels coordinates. Implementing also the rotation from...2020-12-22T13:58:12ZFederico Di PierroSolving a bug in MAGIC tels coordinates. Implementing also the rotation from...Solving a bug in MAGIC tels coordinates. Implementing also the rotation from corsika to geographical frame.Solving a bug in MAGIC tels coordinates. Implementing also the rotation from corsika to geographical frame.Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/14Using PointingContainer instead of TelescopePointingContainer as introduced b...2020-12-18T17:44:06ZFederico Di PierroUsing PointingContainer instead of TelescopePointingContainer as introduced by ctapipe 0.8This modification should fix the error in the array_pointing calculation. Fixes #9.This modification should fix the error in the array_pointing calculation. Fixes #9.Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/13Adding a value for reuse of showers2020-12-14T15:38:36ZFederico Di PierroAdding a value for reuse of showersInstead of leaving shower_reuse as Nan, we set it to 1, because the number of showers in the MAGIC root file already include the shower's reuses, but further analysis step (e.g. pyIRF) may want to use the "reuse" value.Instead of leaving shower_reuse as Nan, we set it to 1, because the number of showers in the MAGIC root file already include the shower's reuses, but further analysis step (e.g. pyIRF) may want to use the "reuse" value.Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/12Add general run-wise MC info2020-12-11T13:49:10ZFederico Di PierroAdd general run-wise MC infoIn the previous version general MC information were not read from the MARS root files. With this new version is possible to fill part of the ctapipe MCHeaderContainer.
Added also specific reference to uproot3.In the previous version general MC information were not read from the MARS root files. With this new version is possible to fill part of the ctapipe MCHeaderContainer.
Added also specific reference to uproot3.Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/11Dev mhuetten ctapipe0.82020-07-27T15:58:38ZMoritz HuettenDev mhuetten ctapipe0.8Update to work with ctapipe 0.8.0, including coding style improvement:
- application of autopep8
- pyflakes
- pylint
Note: Still carrying a local PixelStatusContainer(), as no timing information seems to be included in that one in ctapip...Update to work with ctapipe 0.8.0, including coding style improvement:
- application of autopep8
- pyflakes
- pylint
Note: Still carrying a local PixelStatusContainer(), as no timing information seems to be included in that one in ctapipe 0.8.0. Consider to move to same implementation as for PedestalContainer() and ask for ctapipe pull request.
Did not do a tag so far (propose 0.3.0), as would wait for after some additional testingctapipe 0.8Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/10Dev mhuetten bitflip bugfix2020-07-09T14:16:40ZMoritz HuettenDev mhuetten bitflip bugfixLea found a bug in the bitflip check when reading Monte Carlo files, and I found another one.Lea found a bug in the bitflip check when reading Monte Carlo files, and I found another one.Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/9Dev mhuetten hotpixels2020-07-08T16:12:50ZMoritz HuettenDev mhuetten hotpixelsThis version reads pedestal information and subrun-wise bad pixels from MARS files and stores them in appropriate containers (current ctapipe containers slightly extended and duplicated at end of file, for stability to work together with...This version reads pedestal information and subrun-wise bad pixels from MARS files and stores them in appropriate containers (current ctapipe containers slightly extended and duplicated at end of file, for stability to work together with https://gitlab.mpcdf.mpg.de/ievo/magic-cta-pipe/-/blob/dev-mhuetten-badpixels_class/utils/MAGIC_Badpixels.py). The info can then be used to find bad and hot pixels by https://gitlab.mpcdf.mpg.de/ievo/magic-cta-pipe/-/blob/dev-mhuetten-badpixels_class/utils/MAGIC_Badpixels.py.Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/8README update2020-06-17T17:26:36ZMoritz HuettenREADME updateOnce this update is merged to master, I will make a pull request at https://github.com/cta-observatory for the latest master to be synchronized with https://github.com/cta-observatory/ctapipe_io_magicOnce this update is merged to master, I will make a pull request at https://github.com/cta-observatory for the latest master to be synchronized with https://github.com/cta-observatory/ctapipe_io_magichttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/7Check for bit flipped event IDs2020-06-17T17:26:33ZMoritz HuettenCheck for bit flipped event IDsAfter some discussion with Julian, we noted that sometimes event ids are corrupt. This fix detects non consecutive jumps in the id numbers and removes the affected events from the stereo pairing. In MARS there isn't such a fix, but Julia...After some discussion with Julian, we noted that sometimes event ids are corrupt. This fix detects non consecutive jumps in the id numbers and removes the affected events from the stereo pairing. In MARS there isn't such a fix, but Julian is planning to do a minor release to treat these rare casesAlessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/6add trigger id to event containers2020-06-17T17:27:38ZMoritz Huettenadd trigger id to event containerssolves #6solves #6Alessio BertiAlessio Bertihttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/5Modifications in storing both true_alt and true_az2020-02-17T09:12:52ZYusuke SudaModifications in storing both true_alt and true_azMoritz HuettenMoritz Huettenhttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/4Remove old weather data implementation from master branch2020-01-29T09:04:24ZMoritz HuettenRemove old weather data implementation from master branchRemove implementation of current weather/atmospheric monitoring data reading, as https://github.com/cta-observatory/ctapipe/pull/1210 suggests that implementation should be properly done in a different way. According development will be ...Remove implementation of current weather/atmospheric monitoring data reading, as https://github.com/cta-observatory/ctapipe/pull/1210 suggests that implementation should be properly done in a different way. According development will be done in a separate branch. Also remove dependency of some "WeatherContainer" in ctapipe.Ievgen VovkIevgen Vovkhttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/3bugfix to find correct event numbers when single tel file is read2020-01-29T08:19:22ZMoritz Huettenbugfix to find correct event numbers when single tel file is readSolve #3 and #4. Regarding #4, when a single MC file is read, all events are classified as "mono". Later stereo matching can be done by hand by the event_id. All real "mono" events no having a stereo partner, do have the event_id = 0 (as...Solve #3 and #4. Regarding #4, when a single MC file is read, all events are classified as "mono". Later stereo matching can be done by hand by the event_id. All real "mono" events no having a stereo partner, do have the event_id = 0 (as before).Ievgen VovkIevgen Vovkhttps://gitlab.mpcdf.mpg.de/ievo/ctapipe_io_magic/-/merge_requests/2Dev mhuetten unify datamc2019-12-19T14:03:32ZIevgen VovkDev mhuetten unify datamcI propose to merge this with the main branch after a small revision (thus WIP prefix for now).I propose to merge this with the main branch after a small revision (thus WIP prefix for now).Moritz HuettenMoritz Huetten