The one place for your designs
To enable design management, you'll need to meet the requirements. If you need help, reach out to our support team for assistance.
default reference time in extract_temperature_profile_from_DL causes download_heatflux_scene_model_reference to fail
the default for reference_time = 0 in extract_temperature_profile_from_DL, which calls download_heatflux_scene_model_reference with timepoint = reference_time causes this function to fail because it checks if timepoint == None. Since this isn't the case, it tries to load the parlog version of nanosecond 0, which is None. None is then parsed as string and put in the url that is called, which obviously fails.
This can be fixed immediately by making the reference_time default = None in extract_temperature_profile_from_DL.
But fundamentally it shows a number of problems:
- check against boolean, not specifically 0, None, len==0, or False to avoid this confusion.
- get_latest_version should return only ever return an int. this saves many checks down the line.
- Similarly if download_heatflux_scene_model_reference encounters an error, why bother with printing it and returning False, {}? Unless we have an alternative cached version or something we are stuck anyway. Instead of checking success further down the line we could have just let the code fail and get the error and stacktrace.