GitLab

Anything if it makes Andreas happy :)

The timer object was not properly removed when elpa_destroy() was called
on an ELPA instance, leading to a memory leak

Previously you could set up ELPA with nev > na and force a crash.

We got reports from a user that there were troubles with certain domain
decompositions. So far the tests only looked at (approximately) square
decompositions in column-major process order.

Now, a new class of tests loops over all possible decompositions
(row * col) for a given number of total tasks.

So far, we can not confirm that there are any problems, all
possibilities work as expected.

There was again a case where stack-variables were loaded with
instructions that needed properly aligned memory. This only surfaced
with the Intel C compiler, where the stack layout evidently was
sufficiently different to trigger this.

This was also the case for SSE kernels

Previously we checked ortonormality of eigenvectors by comparing
the matrix S^T * S to identity matrix. The new feature is also
checking just the diagonal of the matrix S^T * S. By that we get
the information, how far are the eigenvectors from having length 1.
If it turns out to be important, we could try to normalize them
at the end of elpa, which is simple (in contrast with enforcing
better orthogonality).

This stupid bug was there since commit ae45bbb3

of _GEMM and P_GEMM calls

PGI has problems with elpa_int_value_to_string() where we return a
variable-length string pointer. A workaround for now is to copy the string into
a non-pointer variable of the same length.

This closes issue #55

This prevented compilation with Intel 2018 Beta and solves issue #54. It
turns out you can only override type-bound procedures that are
accessible in the module where you override them, thus they have to be
private. A "deferred, private" type bound procedure could only be
overriden from the same module (or a submodule thereof).

Many thanks to Igor Vorobtsov from Intel for clarifying this.

Pavel noted that some header files were missing from the distribution.
Also, I moved the private generated header files to src/ in order to
more clearly separate them.