Variuos fix and improvements

assets/installer.sh

+#!/bin/bash
+############################################################################################################### 
+## Copyright (C) 2020 Udo von Toussaint, F. J. Dominguez-Gutierrez, Markus Rampp, Michele Compostella 
+##              Max-Planck-Institut für Plasmaphysik, Boltzmannstrasse 2, 85748 Garching, Germany 
+##              Max-Planck Computing and Data Facility, Giessenbachstrasse 2, 85748 Garching, Germany 
+## 
+## This program is free software; you can redistribute it and/or modify 
+## it under the terms of the GNU General Public License as published by 
+## the Free Software Foundation; either version 2, or (at your option) 
+## any later version. 
+## 
+## This program is distributed in the hope that it will be useful, 
+## but WITHOUT ANY WARRANTY; without even the implied warranty of 
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the 
+## GNU General Public License for more details. 
+## 
+## You should have received a copy of the GNU General Public License 
+## along with this program; if not, write to the Free Software 
+## Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
+## 02110-1301, USA. 
+## 
 #########################################################################
 # This installer works on Ubuntu 18.04 LTS
 #
-# It installs for the user all requirement for running
-# the fingerprinting and visualization of defects in
-# damages crystal structures
+# It installs all the requirements for running the fingerprinting 
+# and visualization of defects in damages crystal structures
 #
-# Run as root with:
+# Run with (requires root permissions):
 # ./installer.sh /installation_path/ full_name email_address organization
 #
 # For example:
@@ -16,14 +36,18 @@
 #
 #########################################################################
 
+# echo an error message if any command fails 
+set -e
+
 # Updating distro and installing packages
 echo "Updating LINUX distribution..."
-apt update
-apt upgrade -y
+sudo apt update
 
 echo "Installing LINUX packages..."
-apt install -y gcc gfortran libblas-dev liblapack-dev python python-pip python3 python3-pip ffmpeg imagemagick
-apt install -y libsm6 libgl1 libgl1-mesa-dri libgl1-mesa-glx libpcre3-dev libxt6
+sudo apt install gcc gfortran libblas-dev liblapack-dev python python-pip python3 python3-pip ffmpeg imagemagick libsm6 libgl1 libgl1-mesa-dri libgl1-mesa-glx libpcre3-dev libxt6
+
+# Storing repository location
+REPO_FOLDER="$( cd "$(dirname "$0")" ; pwd -P )"
 
 # Creating software folder
 mkdir -p $1
@@ -64,7 +88,8 @@ pushd $1
 
   # Installing KDTREE
   echo "Installing KDTREE..."
-  tar xvzf ~/kdtree2.tar.gz -C $1/.
+  KDTREE_PATH=$REPO_PATH/../software/
+  tar xvzf $KDTREE_PATH/kdtree2.tar.gz -C $1/.
   cd kdtree2/
   gfortran -c kdtree2.f90
   gfortran -o kdtree2_iaea_v03.x kdtree2_iaea_v03.f90 kdtree2.o
@@ -82,14 +107,15 @@ pushd $1
   mkdir archive/
   mv ./QUIP/GAP.tar.gz archive/
   mv ./voro++-0.4.6.tar.gz archive/
-  mv ~/kdtree2.tar.gz archive/
+  cp $KDTREE_PATH/kdtree2.tar.gz archive/
   mv ./visit2_13_3.linux-x86_64-ubuntu18-wmesa.tar.gz archive/
   mv ./visit-install2_13_3 archive/
 
 popd
 
 echo
-echo "Installation complete"
+echo "Installation complete!"
+echo "A copy of the installed packages is available in $1/archive"
 echo
 
 exit 0